From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id dgiCCCQfbGIrVwMAWB0awg (envelope-from ) for ; Fri, 29 Apr 2022 13:23:48 -0400 Received: by simark.ca (Postfix, from userid 112) id 17E421E058; Fri, 29 Apr 2022 13:23:48 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=hn50ocE2; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A1A6B1E01D for ; Fri, 29 Apr 2022 13:23:47 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4A83F3858010 for ; Fri, 29 Apr 2022 17:23:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4A83F3858010 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1651253027; bh=l7HhXzexFezbf7kpy0r2CzhHR1fbkt3qVRAHTh7Hm3A=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=hn50ocE2dL73ETfBrtXIXbIZ6anPwnxn4BzKY8kTXMVWlOJmfqMD5Xgb8TWPT8prB jkSLR/ws29lfJm5F2nemO8NzLKsg/AUEGwZXxFSKRMzruo4doAqTq7Kg8nH7jSknu0 Ndr6SQ4Z+WDIf3p7dtmJMNU7ZaOMZA16YKYk/baI= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 0AE303858D1E for ; Fri, 29 Apr 2022 17:23:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0AE303858D1E Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 2004C81D8F; Fri, 29 Apr 2022 17:23:27 +0000 (UTC) Date: Fri, 29 Apr 2022 17:23:18 +0000 To: Keith Seitz Subject: Re: [PATCH] Fix gdb.cp/no-dmgl-verbose.exp test Message-ID: <20220429172308.znoukencrgwgfzav@ubuntu.lan> References: <5ee342cd5f5272da9970da8a077c2c5209b85d6c.camel@us.ibm.com> <20220429091234.62xhprge74gfpgks@ubuntu.lan> <4610920e52ea1bbeb5181c970887eb7cfe344f1a.camel@us.ibm.com> <032437ea-2ef4-90f5-7b96-8a729bae2252@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <032437ea-2ef4-90f5-7b96-8a729bae2252@redhat.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 29 Apr 2022 17:23:27 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Ulrich Weigand , Rogerio Alves , gdb-patches@sourceware.org, Pedro Alves Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, Apr 29, 2022 at 10:09:49AM -0700, Keith Seitz wrote: > On 4/29/22 09:57, Pedro Alves wrote: > > On 2022-04-29 16:48, Carl Love via Gdb-patches wrote: > > > On Fri, 2022-04-29 at 09:14 +0000, Lancelot SIX wrote: > > > > So the file is called gdb.cp/no-dmgl-verbose.exp. "no-dmgl" most certainly means "no demangle". > > > > How is that related to "no demangle verbose" ? A mystery. > > I believe I remember some history of this... > > When I did the physname work years ago, a maintainer objected that the > recorded physname for a function which takes a std::string was > "reduced" to "std::string" instead of recording (and > thus subsequently printing) "std::string" like other tools do. [He > speciifcally mentioned "nm".] > > The "no-dmgl-verbose" refers to the demangler option, DMGL_VERBOSE, > which I originally used when computing physnames. I believe this test's > intention was to make sure that DMGL_VERBOSE didn't creep back into the > code. > > [Background: At the time, the compiler did not output sufficient debuginfo > for a bunch of symbols, such as ctors. Thus the physname computation > was a way to "fill-in" this missing/necessary information.] > > There's a number of other workarounds for this "std::string" > vs "std::string" (and others) in cp-support.c. > See "ignore_typedefs". [Pardon if my explanation is imprecise. > This was a looong time ago.] > > Keith > Hi, Thanks for the history perspective. I was digging in the commits logs, and this commit was introduced by 3f542ed1a314b4831f71ade5006d1926d58f8303. This test removed the DMGL_VERBOSE option. I mainly did that because I was wondering if the test name was still appropriate (I kind of think it is not), but I do not have a "good" name to propose just yet. Best, Lancelot.