From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IiEJOxWHWWIdaQAAWB0awg (envelope-from ) for ; Fri, 15 Apr 2022 10:54:13 -0400 Received: by simark.ca (Postfix, from userid 112) id DFBFC1F327; Fri, 15 Apr 2022 10:54:13 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 674A01ED17 for ; Fri, 15 Apr 2022 10:54:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 7DE50385B23B for ; Fri, 15 Apr 2022 14:54:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DE50385B23B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650034452; bh=aGEYidTCaCE460HuYz0regjbhNzNB8dXRZLxhSZiQ8M=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=bfBokRBTEFqFIJFit4JuV+bT0pCttj7i/ORWUS/K9X7pKs7cY1hQqZZ7IpzJZSDUw rycvhivJ5oaH8LSIHdPulJgNxkJYNtR3ZtZBuet6Zpt/9Ar/5dUld51gKOQ1NGBfPV pvwfY4h1eN8Iuw/xQGAKL93X14Ip731yZGj1FBGA= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 221743857C4E for ; Fri, 15 Apr 2022 14:53:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 221743857C4E Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 414DD1F37E for ; Fri, 15 Apr 2022 14:53:53 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 293B9139B3 for ; Fri, 15 Apr 2022 14:53:53 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id bGxoCAGHWWK7cQAAMHmgww (envelope-from ) for ; Fri, 15 Apr 2022 14:53:53 +0000 Date: Fri, 15 Apr 2022 16:53:51 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.go/methods.exp with check-readmore Message-ID: <20220415145350.GA25415@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When running test-case gdb.go/methods.exp with make check we have: ... (gdb) break main.T.Foo^M Function "main.T.Foo" not defined.^M Make breakpoint pending on future shared library load? (y or [n]) n^M (gdb) XFAIL: gdb.go/methods.exp: gdb_breakpoint: set breakpoint at main.T.Foo ... but with make check-readmore the XFAIL fails to trigger: ... (gdb) break main.T.Foo^M Function "main.T.Foo" not defined.^M Make breakpoint pending on future shared library load? (y or [n]) n^M (gdb) FAIL: gdb.go/methods.exp: gdb_breakpoint: set breakpoint at main.T.Foo ... This happens because this gdb_test_multiple "maintenance print symbols" regexp: ... -re "\r\n$gdb_prompt $" { ... matches the entire command output. Fix this by adding the missing ^ at the regexp start. Tested on x86_64-linux. Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29064 Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.go/methods.exp with check-readmore --- gdb/testsuite/gdb.go/methods.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.go/methods.exp b/gdb/testsuite/gdb.go/methods.exp index aabf1fa5e09..d50fbde122c 100644 --- a/gdb/testsuite/gdb.go/methods.exp +++ b/gdb/testsuite/gdb.go/methods.exp @@ -49,7 +49,7 @@ gdb_test_multiple "maintenance print symbols" "" { -re "^\r\n void main.T.Bar\[^\r\n\]*(?=\r\n)" { exp_continue } - -re "\r\n$gdb_prompt $" { + -re "^\r\n$gdb_prompt $" { pass $gdb_test_name } -re "\r\n\[^\r\n\]*(?=\r\n)" {