From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7hSoBxrIWWKucwAAWB0awg (envelope-from ) for ; Fri, 15 Apr 2022 15:31:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 0D80F1F327; Fri, 15 Apr 2022 15:31:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8C25F1E150 for ; Fri, 15 Apr 2022 15:31:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2457B385741A for ; Fri, 15 Apr 2022 19:31:37 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2457B385741A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1650051097; bh=RNwhDewdIB3TzDfgk7104zIihDvGhOEtRlATTA4ZtIk=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=lyJdcKLpWUXKmbWcxfr2lx15NJUvPlj5LWsGDHxju8qPdOwKDwpt3YGsy7LgA0WPT F3WCPWRxpWCivS+HnOljaAHKB6qHvwD42ixAvvK9UYQt7q98FKvFttMVDuFQau0FAb l6aRL2wRAcp/Yo8F2cb4Po/1YTqi40RGTx6h9UpE= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id E3E3B385842B for ; Fri, 15 Apr 2022 19:31:18 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E3E3B385842B Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-139-bQnEMlT3OeCE3DSQp0jsgg-1; Fri, 15 Apr 2022 15:31:15 -0400 X-MC-Unique: bQnEMlT3OeCE3DSQp0jsgg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 19F12101AA44; Fri, 15 Apr 2022 19:31:15 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.56]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 878CB20296A7; Fri, 15 Apr 2022 19:31:14 +0000 (UTC) Date: Fri, 15 Apr 2022 12:31:12 -0700 To: "Potharla, Rupesh" Subject: Re: GDB/Fortran: Support for Assumed Rank Zero. Message-ID: <20220415123112.697ff872@f35-zws-1> In-Reply-To: References: <20220413112753.4c6f1128@f35-zws-1> <20220414142845.281b878d@f35-zws-1> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: "George, Jini Susan" , "Parasuraman, Hariharan" , "Sharma, Alok Kumar" , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, 15 Apr 2022 13:33:03 +0000 "Potharla, Rupesh" wrote: > Apologies for missing out on these minor things. Followed GDB > standard for comments and updated the attached patch. The comments look good now. Thanks for fixing them. > Regarding XFAIL for flang, I looked at all possible cases in the > testcase where this can be handled and came up this solution which > will not suppress the actual failure case. As the issue will be > fixed by the compiler soon, added the condition based on test > number. I suggest using setup_xfail within the loop when $test_count is 1. Kevin