From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3c0XK/9PTGIveQAAWB0awg (envelope-from ) for ; Tue, 05 Apr 2022 10:19:43 -0400 Received: by simark.ca (Postfix, from userid 112) id A845D1F344; Tue, 5 Apr 2022 10:19:43 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3E5061E787 for ; Tue, 5 Apr 2022 10:19:43 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EBD5B3860825 for ; Tue, 5 Apr 2022 14:19:42 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EBD5B3860825 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649168383; bh=blHIn/EVzEgS2DUbDVmqDGZUjFfxl/t6X6lnoB95GXE=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Tzrf0gh4WS304hKCUVGGe8GJpmCMQ8fCxnAah1Q2ocr+fxKzymyOfRno9aXU3Z4KX ON2wYRPq/qHNsP6rX7kQz3YkWQxehZhokHACqjcWHkLDeXdcAG044Nvv/ZjiNAENPF Mw1aYEEOjdysJUo0AOcWtb6t5EPAgvfxdBqZWg9g= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 710173858405 for ; Tue, 5 Apr 2022 14:19:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 710173858405 Received: from ubuntu (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 789BF80D60; Tue, 5 Apr 2022 14:19:22 +0000 (UTC) Date: Tue, 5 Apr 2022 14:19:17 +0000 To: Jan Vrany Subject: Re: [PATCH] gdb: skip objfiles with no BFD in DWARF unwinder Message-ID: <20220405141802.axq5dwhxc3iyfkmz@ubuntu> References: <20220405100429.188136-1-jan.vrany@labware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20220405100429.188136-1-jan.vrany@labware.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Tue, 05 Apr 2022 14:19:22 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, > diff --git a/gdb/testsuite/gdb.base/jit-reader.exp b/gdb/testsuite/gdb.base/jit-reader.exp > index d94360cd7d9..0de552b1ce5 100644 > --- a/gdb/testsuite/gdb.base/jit-reader.exp > +++ b/gdb/testsuite/gdb.base/jit-reader.exp > @@ -271,6 +271,16 @@ proc jit_reader_test {} { > "#1 ${any} in main ${any}" \ > ] > } > + > + # check that the DWARF unwinder does not crash in presence of > + # JIT objfiles. > + gdb_test "fin" \ > + [multi_line \ > + "Run till exit from ${any} jit_function_stack_mangle ${any}" \ > + "main ${any} at ${any}.*" \ > + ] > + gdb_test "bt" "#0 main ${any} at ${any}" > + gdb_test "next" > } The tests above use with_test_prefix to create logical blocks. You probably want to wrap what you just added in a similar construct. This is for consistency, it creates .sum/.log files easier to work with and also if one wants to add other commands just below those one, we do not risk having DUPLICATE test names. Best, Lancelot.