From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YkvnItlyS2LzVwAAWB0awg (envelope-from ) for ; Mon, 04 Apr 2022 18:36:09 -0400 Received: by simark.ca (Postfix, from userid 112) id 7DA591F344; Mon, 4 Apr 2022 18:36:09 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 130061ED17 for ; Mon, 4 Apr 2022 18:36:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8D0B3385801E for ; Mon, 4 Apr 2022 22:36:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8D0B3385801E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1649111768; bh=e5yDJpa5Zn07FOJjU4+bLomYZsIve8SvUomFTncemcs=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yrjFY5LZvYwzYAtonLngFaHMvQRFaAQB7VknrWixACgv/aZM8cEVmM4R2X3vpjivR 3xJYtxTBuj7rZChJAGc9AIbbtKKoa5LsoltbB8SJ/rtdxVMIqpWz2EILtfihX5H6JR uA4zCXOTSNzH9dGa3Pl9B80t1Tg7KjwXWamgUPMU= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 053A83858D37 for ; Mon, 4 Apr 2022 22:35:49 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 053A83858D37 Received: from ubuntu (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id E5E3B81804; Mon, 4 Apr 2022 22:35:47 +0000 (UTC) Date: Mon, 4 Apr 2022 22:35:39 +0000 To: Andrew Burgess Subject: Re: [PATCH 03/16] gdb: make gdbarch_register_reggroup_p take a const reggroup * Message-ID: <20220404223527.l7k3ekywgszcyw4d@ubuntu> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Mon, 04 Apr 2022 22:35:48 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, > diff --git a/gdb/arm-tdep.c b/gdb/arm-tdep.c > index 4d0f3492410..c857f5ca7d1 100644 > --- a/gdb/arm-tdep.c > +++ b/gdb/arm-tdep.c > @@ -8986,7 +8986,7 @@ arm_elf_osabi_sniffer (bfd *abfd) > > static int > arm_register_reggroup_p (struct gdbarch *gdbarch, int regnum, > - struct reggroup *group) > + const struct reggroup *group) ^ Small nit, looks like you dropped a space here. Best, Lancelot.