From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hChDJsQFQ2KqXgAAWB0awg (envelope-from ) for ; Tue, 29 Mar 2022 09:12:36 -0400 Received: by simark.ca (Postfix, from userid 112) id 8BB2F1F0B6; Tue, 29 Mar 2022 09:12:36 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 89A821ED17 for ; Tue, 29 Mar 2022 09:12:35 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 26A37385DC02 for ; Tue, 29 Mar 2022 13:12:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 26A37385DC02 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1648559555; bh=Db9HCTP/l+l5vEaE2G3BY7AxhOu6lKOd5Uvvyw0Kha0=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=WiH5j9E5Ng+AF7f5nfJmfD1Vp2GtlK61OtYdpcAxbHWZFZTSrKLloB6RoLLnkCw8k TyEI9t0J8yOkiOlWc1neJql9ZRunmafbj6YTjwpVk8dkDspEYjawVoA2kokwti/f1F Tq2WcyBnkgphNC916vmYHfpvTiLRjexAJHhvbYS8= Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by sourceware.org (Postfix) with ESMTPS id C06EE3858C50 for ; Tue, 29 Mar 2022 13:12:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C06EE3858C50 X-IronPort-AV: E=McAfee;i="6200,9189,10300"; a="284145666" X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="284145666" Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 06:12:14 -0700 X-IronPort-AV: E=Sophos;i="5.90,220,1643702400"; d="scan'208";a="604771398" Received: from labpc2315.iul.intel.com (HELO localhost) ([172.28.50.57]) by fmsmga008-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 29 Mar 2022 06:12:13 -0700 To: gdb-patches@sourceware.org Subject: [PATCH v2 0/3] Apply fixme notes for multi-target support Date: Tue, 29 Mar 2022 15:11:55 +0200 Message-Id: <20220329131158.3970228-1-christina.schimpe@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christina Schimpe via Gdb-patches Reply-To: Christina Schimpe Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi all, This is the V2 for the series "Apply fixme notes for multi-target support" based on the feedback of Tom and Andrew. I am sorry that it took so long to get to. V1 of this series can be found here: https://sourceware.org/pipermail/gdb-patches/2022-January/185091.html. Changes for patch #1: * Remove obsolete 'remote_state *' parameters. * Extract packet number using the 'context' attached to the command. * Enhance commit message. * Adapt the logging for the 'show remote PACKET-NAME' and added logging for the 'set remote PACKET-NAME' commands for the new command behavior. I chose a very similar logging to the one Andrew suggested in the review for V1 of this series. * Adapt tests for the new logging. * Add NEWS entry. * Update the documentation. * Add comments. * Move smaller functions inside the new struct remote_features. Changes for patch #2: * Adapt the behavior of the 'show remote memory-read/write-packet-size' commands such that they behave similar to the previous patch e.g. "The show command always displays the current remote target's configuration. If no remote target is selected the default configuration for future connections is shown". * Adapt the commit message accordingly. * Adapt the logging for the 'set remote memory-read/write-packet-size' and added logging for the 'set remote memory-read/write-packet-size' commands. * Adapt tests for the new logging. * Add NEWS entry. * Update the documentation. * Add comments. * Cosmetic changes. I did not make any changes to patch #3 of this series (https://sourceware.org/pipermail/gdb-patches/2022-January/185090.html). Reasoning for this is described in https://sourceware.org/pipermail/gdb-patches/2022-January/185560.html. Please let me know if you have comments on the patch or if it is acceptable as is. Thanks, Christina Christina Schimpe (3): gdb: Make global feature array a per-remote target array gdb: Add per-remote target variables for memory read and write config gdb: Remove workaround for the vCont packet gdb/NEWS | 25 + gdb/doc/gdb.texinfo | 24 +- gdb/remote.c | 1469 +++++++++-------- gdb/testsuite/gdb.base/cond-eval-mode.exp | 9 +- gdb/testsuite/gdb.base/dprintf.exp | 5 +- gdb/testsuite/gdb.base/find-unmapped.exp | 5 +- .../gdb.base/hbreak-in-shr-unsupported.exp | 4 +- gdb/testsuite/gdb.base/remote.exp | 45 +- .../gdb.multi/multi-target-info-inferiors.exp | 6 +- gdb/testsuite/gdb.multi/multi-target.exp.tcl | 8 +- .../connect-without-multi-process.exp | 4 +- .../gdb.server/exit-multiple-threads.exp | 9 +- gdb/testsuite/gdb.server/ext-restart.exp | 5 +- gdb/testsuite/gdb.server/ext-wrapper.exp | 5 +- gdb/testsuite/gdb.server/server-exec-info.exp | 5 +- gdb/testsuite/gdb.server/server-kill.exp | 4 +- .../gdb.server/stop-reply-no-thread-multi.exp | 8 +- .../gdb.server/stop-reply-no-thread.exp | 9 +- .../process-dies-while-handling-bp.exp | 9 +- gdb/testsuite/gdb.trace/change-loc.exp | 4 +- gdb/testsuite/gdb.trace/qtro.exp | 6 +- 21 files changed, 976 insertions(+), 692 deletions(-) -- 2.25.1 Intel Deutschland GmbH Registered Address: Am Campeon 10, 85579 Neubiberg, Germany Tel: +49 89 99 8853-0, www.intel.de Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva Chairperson of the Supervisory Board: Nicole Lau Registered Office: Munich Commercial Register: Amtsgericht Muenchen HRB 186928