From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id wI9pOc6cDGImJwAAWB0awg (envelope-from ) for ; Wed, 16 Feb 2022 01:42:22 -0500 Received: by simark.ca (Postfix, from userid 112) id DA91B1F3C9; Wed, 16 Feb 2022 01:42:22 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B0F91EA69 for ; Wed, 16 Feb 2022 01:42:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id C893F3857C59 for ; Wed, 16 Feb 2022 06:42:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C893F3857C59 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644993736; bh=pUWLEE19dpq9+piR28ZGRmP4MP1KpaxV+Cq8XaQi0vg=; h=To:In-Reply-To:Subject:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=RaPVEtMfOgjBE6CSb6bXuYy4UMXkbjmaGl7oZx4FAyqQIQNUG6NehPNjJdfR1zFyp 1IFhXdOcxXd20dC/dUpb3c9PBfDT662+bgTfdwoqhC+7ugKhNDGNjVQ9tQcQC6efz6 Yp8LbVnV365KGUyAv6ViXYe6ks9nIISnEFrXb1gA= Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id B5CA93858D3C for ; Wed, 16 Feb 2022 06:41:58 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B5CA93858D3C To: Mike Frysinger In-Reply-To: (message from Mike Frysinger on Wed, 16 Feb 2022 00:02:23 -0500) Subject: Re: [PATCH 10/12] sim: Add sim_dump_memory for debugging MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230631.BA3A320439@pchp3.se.axis.com> Message-ID: <20220216064157.9F54F20417@pchp3.se.axis.com> Date: Wed, 16 Feb 2022 07:41:57 +0100 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hans-Peter Nilsson via Gdb-patches Reply-To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Wed, 16 Feb 2022 00:02:23 -0500 > From: Mike Frysinger > On 15 Feb 2022 00:06, Hans-Peter Nilsson via Gdb-patches wrote: > > --- a/sim/common/sim-memopt.c > > +++ b/sim/common/sim-memopt.c > > > > +/* Convenience function for use when debugging the simulator. */ > > can you clarify that it's meant for an attached debugger to call vs a > manual call from within the sim itself ? i know your commit message > said that, but the code comment would help too. Committed. ---- 8< ---- sim/common: Improve sim_dump_memory head comment As requested by Mike. * sim-memopt.c: Improve head comment. --- sim/common/sim-memopt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/sim/common/sim-memopt.c b/sim/common/sim-memopt.c index 62423421cf9c..1f7186c5e12d 100644 --- a/sim/common/sim-memopt.c +++ b/sim/common/sim-memopt.c @@ -641,7 +641,8 @@ sim_memory_uninstall (SIM_DESC sd) void sim_dump_memory (SIM_DESC sd); -/* Convenience function for use when debugging the simulator. */ +/* Convenience function for use when debugging the simulator, to be + called from within e.g. gdb. */ void sim_dump_memory (SIM_DESC sd) -- 2.30.2