From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id YMLEGGeVDGK/JQAAWB0awg (envelope-from ) for ; Wed, 16 Feb 2022 01:10:47 -0500 Received: by simark.ca (Postfix, from userid 112) id 62B821F3C9; Wed, 16 Feb 2022 01:10:47 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F20A51EA69 for ; Wed, 16 Feb 2022 01:10:46 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96BBC3857C41 for ; Wed, 16 Feb 2022 06:10:46 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 96BBC3857C41 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644991846; bh=MtziWW7I9/BWkvuT7EE7EOKLgVH927CQD7Y2D4D7MN0=; h=To:In-Reply-To:Subject:References:Date:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=oCqc0myyp3hoCUtjnW5ZT7JxXLt0VWISHtx53JRsMCN/EJVRfZiA7AxxDYdf2gO6E 7BTccBg1UYqWQ9HCk4jLykpeSPan9ePImoq5o5558i1WDW0Zq80m4Z5Jl/3PClLcEx 1ZS7U04gWeQ2QmaXDk3RIjkAmbFJ8AZragp86SHw= Received: from smtp2.axis.com (smtp2.axis.com [195.60.68.18]) by sourceware.org (Postfix) with ESMTPS id 3485B3858D3C for ; Wed, 16 Feb 2022 06:10:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 3485B3858D3C To: Mike Frysinger In-Reply-To: (message from Mike Frysinger on Wed, 16 Feb 2022 00:02:23 -0500) Subject: Re: [PATCH 10/12] sim: Add sim_dump_memory for debugging MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT References: <20220214225824.AC90A20439@pchp3.se.axis.com> <20220214230631.BA3A320439@pchp3.se.axis.com> Message-ID: <20220216061027.1A4682040B@pchp3.se.axis.com> Date: Wed, 16 Feb 2022 07:10:27 +0100 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Hans-Peter Nilsson via Gdb-patches Reply-To: Hans-Peter Nilsson Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > Date: Wed, 16 Feb 2022 00:02:23 -0500 > From: Mike Frysinger > On 15 Feb 2022 00:06, Hans-Peter Nilsson via Gdb-patches wrote: > > --- a/sim/common/sim-memopt.c > > +++ b/sim/common/sim-memopt.c > > > > +/* Convenience function for use when debugging the simulator. */ > > can you clarify that it's meant for an attached debugger to call vs a > manual call from within the sim itself ? i know your commit message > said that, but the code comment would help too. > > i vaguely recall seeing another such hook point in the tree. i wonder > if we should gather the prototypes in a single header and give them a > dedicated symbol prefix to make them easier to discover. as it stands, > i think you're prob the only one who will use this for quite some time > as no one else will notice it :P. > -mike A good idea! brgds, H-P