From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VtQFLNzVAmLuaAAAWB0awg (envelope-from ) for ; Tue, 08 Feb 2022 15:43:08 -0500 Received: by simark.ca (Postfix, from userid 112) id A3B3D1F3C6; Tue, 8 Feb 2022 15:43:08 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 2A9521EE1A for ; Tue, 8 Feb 2022 15:43:08 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 55B4C3858433 for ; Tue, 8 Feb 2022 20:43:07 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 55B4C3858433 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1644352987; bh=yNOb3rZj5k6+0BcoCmQde4iIo1MWt48BDajBmTG6874=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=TS20yHrmrhH5pjCEYHJ82+rKHU4+MInKHr52NjzUsV4Qmbg5IKK8aEwvj/n3BktRH YVeskvjBzrMiu13I0TzNVaR1/5UTnzFA8tg+NhVnMPkp0F/St6keiuhIp0ZtR2ppKZ c+2gIQDZWH+iet6QmMXHQ8ALeuG6W+8u5falT7oo= Received: from mail-il1-x135.google.com (mail-il1-x135.google.com [IPv6:2607:f8b0:4864:20::135]) by sourceware.org (Postfix) with ESMTPS id AAB163858D1E for ; Tue, 8 Feb 2022 20:42:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org AAB163858D1E Received: by mail-il1-x135.google.com with SMTP id z18so33427ilp.3 for ; Tue, 08 Feb 2022 12:42:48 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=yNOb3rZj5k6+0BcoCmQde4iIo1MWt48BDajBmTG6874=; b=4/IapEl66+43lJfyNw2KZpj94I4dRAxR0kXOD+9A9Qzse0acOsMjQuJYj0fzvXnIWh D1bEC7TdQ8fZUjGtVemjlHl7gQi4zfxcTLGom0uybVVoFGLvQxV7okvIAs4LTtR3ScAf /xPyp4owP0bA2XCq4AMEVYklw1NYRQtWB3095OWUg+Q15CmzdhHJ/hdtJJCOu0JueOk/ wXDM/qAo22o2HKA9CnqPVfE4dVuviDAikXQkStXYwnnNu3bvoG2Tp1zMG6OlEGOOfEXr p1ynrEMmWtDFZ36lFj1elBl53Dk7iw8ZG7d4cwKiBACNPaLrqo7NmuECPrJfvTA3xZ7m /A2w== X-Gm-Message-State: AOAM532wkEkFTiV61FCyIyaG5Lw1oCvPRPG6WBzL6lFq2EM46t6ivig8 Qlcn3BDeVYEd0Jdsp9rUxTZb80v4J35xXw== X-Google-Smtp-Source: ABdhPJyrp/opIPFZmoj77oOYFFP/E5Bhnq7/BXLd9DZk1/OlYKLoeVJymLAPmHyRrEFynFTSxTdrtA== X-Received: by 2002:a05:6e02:1d90:: with SMTP id h16mr2855589ila.202.1644352968025; Tue, 08 Feb 2022 12:42:48 -0800 (PST) Received: from murgatroyd.Home (75-166-128-165.hlrn.qwest.net. [75.166.128.165]) by smtp.gmail.com with ESMTPSA id c12sm6796269ilo.70.2022.02.08.12.42.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 08 Feb 2022 12:42:47 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH] Add initializers to bound_minimal_symbol Date: Tue, 8 Feb 2022 13:42:45 -0700 Message-Id: <20220208204245.2186900-1-tromey@adacore.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This adds initializers to bound_minimal_symbol, allowing for the removal of some calls to memset. --- gdb/ada-lang.c | 2 -- gdb/findvar.c | 3 +-- gdb/minsyms.h | 4 ++-- gdb/value.c | 7 +------ 4 files changed, 4 insertions(+), 12 deletions(-) diff --git a/gdb/ada-lang.c b/gdb/ada-lang.c index 0dd83cda8e5..d2f620cbb04 100644 --- a/gdb/ada-lang.c +++ b/gdb/ada-lang.c @@ -4562,8 +4562,6 @@ ada_lookup_simple_minsym (const char *name) { struct bound_minimal_symbol result; - memset (&result, 0, sizeof (result)); - symbol_name_match_type match_type = name_match_type_from_name (name); lookup_name_info lookup_name (name, match_type); diff --git a/gdb/findvar.c b/gdb/findvar.c index 1d22e645305..6660b006795 100644 --- a/gdb/findvar.c +++ b/gdb/findvar.c @@ -404,7 +404,7 @@ symbol_read_needs_frame (struct symbol *sym) struct minsym_lookup_data { /* The name of the minimal symbol we are searching for. */ - const char *name; + const char *name = nullptr; /* The field where the callback should store the minimal symbol if found. It should be initialized to NULL before the search @@ -751,7 +751,6 @@ language_defn::read_var_value (struct symbol *var, struct minimal_symbol *msym; struct obj_section *obj_section; - memset (&lookup_data, 0, sizeof (lookup_data)); lookup_data.name = var->linkage_name (); gdbarch_iterate_over_objfiles_in_search_order diff --git a/gdb/minsyms.h b/gdb/minsyms.h index 5970cb3bb99..ed31d32483a 100644 --- a/gdb/minsyms.h +++ b/gdb/minsyms.h @@ -31,12 +31,12 @@ struct bound_minimal_symbol /* The minimal symbol that was found, or NULL if no minimal symbol was found. */ - struct minimal_symbol *minsym; + struct minimal_symbol *minsym = nullptr; /* If MINSYM is not NULL, then this is the objfile in which the symbol is defined. */ - struct objfile *objfile; + struct objfile *objfile = nullptr; /* Return the obj_section from OBJFILE for MINSYM. */ diff --git a/gdb/value.c b/gdb/value.c index 7bd9891b3e9..76099966f13 100644 --- a/gdb/value.c +++ b/gdb/value.c @@ -3171,13 +3171,8 @@ value_fn_field (struct value **arg1p, struct fn_field *f, struct bound_minimal_symbol msym; sym = lookup_symbol (physname, 0, VAR_DOMAIN, 0).symbol; - if (sym != NULL) + if (sym == nullptr) { - memset (&msym, 0, sizeof (msym)); - } - else - { - gdb_assert (sym == NULL); msym = lookup_bound_minimal_symbol (physname); if (msym.minsym == NULL) return NULL; -- 2.31.1