From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EBYdDer4+2HOBQAAWB0awg (envelope-from ) for ; Thu, 03 Feb 2022 10:46:50 -0500 Received: by simark.ca (Postfix, from userid 112) id 315781F3BA; Thu, 3 Feb 2022 10:46:50 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_MSPIKE_H2, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D6B2D1ECEB for ; Thu, 3 Feb 2022 10:46:49 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B0033858410 for ; Thu, 3 Feb 2022 15:46:49 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B0033858410 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643903209; bh=Lj4l8RPsRhFk6EYcasLa9y9Uv+G8c4F3lKUnx0GmqRY=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wQ4qP7/nzzW7tb0A9C6ysRvjh1HocRtQeiX/y1otrS2Tx5GwyxSkVzyh0SWMWOcTq rXXZyqUccqKiK7OJNP2f7tORtnXR1z9i00UuZObaIMDLg0w/YsTTngqnnZUQVmkVYm OP3nAoqNJEB9TiHlnVfXOMTJa6dB7+1b1KPNPFEk= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id A6C583858D35 for ; Thu, 3 Feb 2022 15:46:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org A6C583858D35 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:8c4a:4874:fbf9:5145]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 90DD081859; Thu, 3 Feb 2022 15:46:28 +0000 (UTC) Date: Thu, 3 Feb 2022 15:46:24 +0000 To: Simon Marchi Subject: Re: [PATCH v4] gdb: add a symbol* argument to get_return_value Message-ID: <20220203154624.m63nmq3wbenwfis2@Plymouth> References: <8ebbde37-0acc-c430-ea36-d21c14163ef8@simark.ca> <20220202215914.23534-1-lancelot.six@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 03 Feb 2022 15:46:28 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: simark@simark.ca, Lancelot SIX , gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > - struct value *func_value; > - > /* Ignore Python errors at this stage. */ > - self_bpfinish->return_type = type_to_type_object (ret_type); > - PyErr_Clear (); > - func_value = read_var_value (function, NULL, frame); > - self_bpfinish->function_value = > - value_to_value_object (func_value); > + value *func_value = read_var_value (function, NULL, frame); > + self_bpfinish->function_value > + = value_to_value_object (func_value); > PyErr_Clear (); > + > + self_bpfinish->func_symbol > + = symbol_to_symbol_object (function); Shouldn’t there be a call to PyErr_Clear () here? (I did forget it initially). Lancelot