From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id UBl6IjCW+GFWDgAAWB0awg (envelope-from ) for ; Mon, 31 Jan 2022 21:08:48 -0500 Received: by simark.ca (Postfix, from userid 112) id 7C9711F3B4; Mon, 31 Jan 2022 21:08:48 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E627F1EDF0 for ; Mon, 31 Jan 2022 21:08:47 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 436D63857C5C for ; Tue, 1 Feb 2022 02:08:47 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 436D63857C5C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643681327; bh=JZBSr91YulI+/we5hRpHlaF32Y0YhxGDQGKZST57LYw=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=wDvS2EdqxFbkWoSp2wyQHvfTdKqLDqQgOqcwsGS/L0HHbciyxFcZ0pCPu50uqJ+rt Qqvgtuj9vfBNHn4ANtTlvbn32FTg6WeEBkwKQ/Y4rNl2AyaFpjcepnmckWAglDMRag i0GkUQbT7NX1uvdCqn0hVXFnWPPIMy4eP4HlKkEk= Received: from hera.aquilenet.fr (hera.aquilenet.fr [IPv6:2a0c:e300::1]) by sourceware.org (Postfix) with ESMTPS id 037A13858D35 for ; Tue, 1 Feb 2022 02:08:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 037A13858D35 Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id C54501DD; Tue, 1 Feb 2022 03:08:27 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at aquilenet.fr Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id snS0LenXxZ4C; Tue, 1 Feb 2022 03:08:27 +0100 (CET) Received: from begin (unknown [IPv6:2a01:cb19:956:1b00:de41:a9ff:fe47:ec49]) by hera.aquilenet.fr (Postfix) with ESMTPSA id 2FDC1137; Tue, 1 Feb 2022 03:08:27 +0100 (CET) Received: from samy by begin with local (Exim 4.95) (envelope-from ) id 1nEian-001C0D-Ue; Tue, 01 Feb 2022 03:08:25 +0100 Date: Tue, 1 Feb 2022 03:08:25 +0100 To: Simon Marchi Subject: Re: [PATCH] hurd: Fix RPC link names Message-ID: <20220201020825.lztddjsvfegkww54@begin> References: <20220201000450.2lfmwt6hwyd2qcg5@begin> <0f896293-65d3-28bf-ef43-d965a1114136@polymtl.ca> <20220201010509.vhrffe26klj26yce@begin> <20220201012313.kvhplo47mk5fe3ch@begin> <48fd3788-7943-6576-3918-748508e26c43@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <48fd3788-7943-6576-3918-748508e26c43@polymtl.ca> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-Spamd-Bar: / X-Rspamd-Server: hera X-Rspamd-Queue-Id: C54501DD X-Spamd-Result: default: False [0.40 / 15.00]; ARC_NA(0.00)[]; RCVD_VIA_SMTP_AUTH(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_DN_SOME(0.00)[]; TO_MATCH_ENVRCPT_ALL(0.00)[]; MIME_GOOD(-0.10)[text/plain]; HAS_ORG_HEADER(0.00)[]; RCVD_COUNT_THREE(0.00)[3]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_LAST(0.00)[]; MID_RHS_NOT_FQDN(0.50)[] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Samuel Thibault via Gdb-patches Reply-To: Samuel Thibault Cc: Thomas Schwinge , gdb-patches@sourceware.org, thomas@schwinge.name Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon Marchi, le lun. 31 janv. 2022 20:31:22 -0500, a ecrit: > On 2022-01-31 20:23, Samuel Thibault wrote: > > Simon Marchi, le lun. 31 janv. 2022 20:05:53 -0500, a ecrit: > >> > >> > >> On 2022-01-31 20:05, Samuel Thibault wrote: > >>> Simon Marchi, le lun. 31 janv. 2022 19:56:35 -0500, a ecrit: > >>>> On 2022-01-31 19:04, Samuel Thibault via Gdb-patches wrote: > >>>>> The RPC stub code expects to be calling a C function, not a C++ > >>>>> function. > >>>>> > >>>>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > >>>>> index 67ce00e9c30..030ccf01d68 100644 > >>>>> --- a/gdb/gnu-nat.c > >>>>> +++ b/gdb/gnu-nat.c > >>>>> @@ -1766,11 +1766,13 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) > >>>>> > >>>>> > >>>>> #define ILL_RPC(fun, ...) \ > >>>>> + extern "C" { \ > >>>>> extern kern_return_t fun (__VA_ARGS__); \ > >>>> > >>>> I think this could be on a single line: > >>>> > >>>> extern "C" kern_return_t fun.. > >>> > >>> Ah right here is a simplified version. > >>> > >>> Samuel > >>> > >>> > >>> The RPC stub code expects to be calling a C function, not a C++ > >>> function. > >>> > >>> diff --git a/gdb/gnu-nat.c b/gdb/gnu-nat.c > >>> index e0219b1a3ff..81676308882 100644 > >>> --- a/gdb/gnu-nat.c > >>> +++ b/gdb/gnu-nat.c > >>> @@ -1766,7 +1766,7 @@ do_mach_notify_dead_name (mach_port_t notify, mach_port_t dead_port) > >>> > >>> > >>> #define ILL_RPC(fun, ...) \ > >>> - extern kern_return_t fun (__VA_ARGS__); \ > >>> + extern "C" kern_return_t fun (__VA_ARGS__); \ > >>> kern_return_t fun (__VA_ARGS__) \ > >>> { \ > >>> warning (_("illegal rpc: %s"), #fun); \ > >> > >> Thanks, this is OK to push. > > > > (I don't have commit access) > > > > Samuel > > Oh, sorry! Pushed it for you. Thanks! Samuel