From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +F6FGRhQ9GHFDAAAWB0awg (envelope-from ) for ; Fri, 28 Jan 2022 15:20:40 -0500 Received: by simark.ca (Postfix, from userid 112) id 65E711F0E7; Fri, 28 Jan 2022 15:20:40 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E8A1A1EDF0 for ; Fri, 28 Jan 2022 15:20:39 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 69050394843F for ; Fri, 28 Jan 2022 20:20:39 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 69050394843F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1643401239; bh=M3PBTMKGrKTOaXbzw2r06j0QTjltSu1nf+rZIppNsEQ=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=cm9aEL6zZcF9r8GOzYqm5krsLRfcW5ZvCdWXVRQ9finGEkqqKibhWBJkmEykzgR9H g8jsNxHLjjQmCjptHAdeCriQPl53qRui3Yn2E8NRA1EdY4HDQcReX7jEt/gtTbspvR qAajpo5z6noCWw3m1AuXcly4AC7YpJlsFRW8ur6Q= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 505763858402 for ; Fri, 28 Jan 2022 20:20:21 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 505763858402 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-440-0kGkBPPqN7WoTBbGqZolIA-1; Fri, 28 Jan 2022 15:20:18 -0500 X-MC-Unique: 0kGkBPPqN7WoTBbGqZolIA-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E638183DD20; Fri, 28 Jan 2022 20:20:17 +0000 (UTC) Received: from f35-zws-1 (unknown [10.2.16.28]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8396956A81; Fri, 28 Jan 2022 20:20:17 +0000 (UTC) Date: Fri, 28 Jan 2022 13:20:15 -0700 To: John Baldwin Subject: Re: [PATCH] gdb: fix ppc-sysv-tdep.c build on 32-bit platforms Message-ID: <20220128132015.3c8ff023@f35-zws-1> In-Reply-To: <20220128192425.76123-1-jhb@FreeBSD.org> References: <20220128192425.76123-1-jhb@FreeBSD.org> Organization: Red Hat MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Kevin Buettner via Gdb-patches Reply-To: Kevin Buettner Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi John, LGTM. Kevin On Fri, 28 Jan 2022 11:24:25 -0800 John Baldwin wrote: > The previous code triggered the following error on an i386 host: > > /git/gdb/gdb/ppc-sysv-tdep.c:1764:34: error: non-constant-expression cannot be narrowed from type 'ULONGEST' (aka 'unsigned long long') to 'size_t' (aka 'unsigned int') in initializer list [-Wc++11-narrowing] > unscaled.read ({writebuf, TYPE_LENGTH (valtype)}, > ^~~~~~~~~~~~~~~~~~~~~ > /git/gdb/gdb/gdbtypes.h:2043:31: note: expanded from macro 'TYPE_LENGTH' > ^~~~~~~~~~~~~~~~~~ > /git/gdb/gdb/ppc-sysv-tdep.c:1764:34: note: insert an explicit cast to silence this issue > unscaled.read ({writebuf, TYPE_LENGTH (valtype)}, > ^~~~~~~~~~~~~~~~~~~~~ > static_cast( ) > /git/gdb/gdb/gdbtypes.h:2043:31: note: expanded from macro 'TYPE_LENGTH' > ^~~~~~~~~~~~~~~~~~ > 1 error generated. > > Fix this by using gdb::make_array_view. > --- > gdb/ppc-sysv-tdep.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/gdb/ppc-sysv-tdep.c b/gdb/ppc-sysv-tdep.c > index 5255cea43e3..9a3b02f028d 100644 > --- a/gdb/ppc-sysv-tdep.c > +++ b/gdb/ppc-sysv-tdep.c > @@ -1761,7 +1761,8 @@ ppc64_sysv_abi_return_value_base (struct gdbarch *gdbarch, struct type *valtype, > /* Fixed point type values need to be returned unscaled. */ > gdb_mpz unscaled; > > - unscaled.read ({writebuf, TYPE_LENGTH (valtype)}, > + unscaled.read (gdb::make_array_view (writebuf, > + TYPE_LENGTH (valtype)), > type_byte_order (valtype), > valtype->is_unsigned ()); > return_val = unscaled.as_integer (); > -- > 2.34.1 >