Re: [PATCH] gdb.dlang/demangle.exp: update expected output for _D8demangle4testFnZv

Iain Buclaw via Gdb-patches
2022-01-14T19:46:22Z

Excerpts from Simon Marchi's message of Januar 13, 2022 5:10 pm:
> Since commit ce2d3708bc8b ("Synchronize binutils libiberty sources with
> gcc version."), I see this failure:
>
> demangle _D8demangle4testFnZv^M
> demangle.test(typeof(null))^M
> (gdb) FAIL: gdb.dlang/demangle.exp: _D8demangle4testFnZv
>
> The commit imported the commit 0e32a5aa8bc9 ("libiberty: Add support for
> D `typeof(*null)' types") from the gcc repository. That commit includes
> an update to libiberty/testsuite/d-demangle-expected, which updates a
> test for the exact same mangled name:
>
> _D8demangle4testFnZv
> -demangle.test(none)
> +demangle.test(typeof(null))
>
> I don't know anything about D, but give that the change was made by Iain
> Buclaw, the D language maintainer, I trust him on that.
>
> Fix our test by updating the expected output in the same way.
>
> Note: it's not really useful to have all these D demangling tests in the
> GDB testsuite, since there are demangling tests in libiberty. We should
> consider removing them, but we first need to make sure that everything
> that is covered in gdb/testsuite/gdb.dlang/demangle.exp is also covered
> in libiberty/testsuite/d-demangle-expected.
>

Hi Simon,

To memory, both gdb and libiberty D demangle tests started out as being
identical, but libiberty has been adding more to it as it's been
improved/updated to support the latest language features. I see no
issues with removing it if it's becoming problematic to maintain both.

Iain.