From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id gBTpBBS41mE2dwAAWB0awg (envelope-from ) for ; Thu, 06 Jan 2022 04:36:20 -0500 Received: by simark.ca (Postfix, from userid 112) id 0F8451EE22; Thu, 6 Jan 2022 04:36:20 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B30311EA69 for ; Thu, 6 Jan 2022 04:36:17 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 577A5385AC22 for ; Thu, 6 Jan 2022 09:36:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 577A5385AC22 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641461777; bh=AFAMajSSflcMNeybYfrGA51GRChcnqPD7Z22MTiywNA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=gSS3pPmIbG4ZfxZCYrdKVuTZapmwrmdA7855C6Hq9Qhlh6gB5CTKGx3MtfQLoGWrh s7liAKLPQMgrPMbb7o19c35//o57bHaoezM50RA2mCB40Ex2uAULvNEuoTm7wxkpE9 lu74klmMAqyb7m/l2aNQpz0Vn3pzy4XxhJ4MfMmI= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 09DD6385AC2D for ; Thu, 6 Jan 2022 09:34:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 09DD6385AC2D Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-507-ffctZbskN3yf2oom8WcEMA-1; Thu, 06 Jan 2022 04:34:41 -0500 X-MC-Unique: ffctZbskN3yf2oom8WcEMA-1 Received: by mail-wr1-f71.google.com with SMTP id v14-20020adfa1ce000000b001a49d6587ceso937572wrv.21 for ; Thu, 06 Jan 2022 01:34:41 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=AFAMajSSflcMNeybYfrGA51GRChcnqPD7Z22MTiywNA=; b=NnilMtUyj/SXtynPfCXdO4nBHlmfJzCm7KEJE5PfFmiUaeqwLXZRBP+4pkkrmAffXO hJGgAfgOLjHLjFt1i/vRQnx3jqE19dgXBs5Pd4A5nPKbQ/AL/9pTo96Q0NYyxKOez9J6 ynEw3oi9pLAzRqkn9iw5rYYhJQj0wCIFkYyqgJN9z0vY146Zf0IctkyjjnR1zVADHcM+ AWpXxbm78ne+w5z7+xJ2/68Gj3WZfBFxwshXTHQGeuQXzdI8wEfW7tBe6vXTQLPVVNuG 4dvYE+NmX1d+q755zOscxT+FDXdufcYCrLQzPSV4dGQMaUO9hy78l9zlplVeh2xTQ2WT cxKQ== X-Gm-Message-State: AOAM530nkJ1NKxQOM+kSzsvDSV6m4VBikjyaFXK6GPzv6Fkf3gML9RCe jL1R6g8BV7g6EVmK/4rr+RU8sVKrzdDUwLeTdcuRoVePwdEXMkaU9hXwPagd2iQZE5ISbT3ZVlg N3Zm1bEd8rHP2tBpx8nVZVQ== X-Received: by 2002:a05:6000:1366:: with SMTP id q6mr4032619wrz.551.1641461680023; Thu, 06 Jan 2022 01:34:40 -0800 (PST) X-Google-Smtp-Source: ABdhPJwJrnjScv07IwzO0si5kEwlbgcfTgSlnRCT3QgiG2zQCo/aqdJWLfzxxq7sAlIphpmhNoEm4w== X-Received: by 2002:a05:6000:1366:: with SMTP id q6mr4032608wrz.551.1641461679778; Thu, 06 Jan 2022 01:34:39 -0800 (PST) Received: from localhost (host109-154-163-67.range109-154.btcentralplus.com. [109.154.163.67]) by smtp.gmail.com with ESMTPSA id m17sm4948787wmq.31.2022.01.06.01.34.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jan 2022 01:34:39 -0800 (PST) Date: Thu, 6 Jan 2022 09:34:38 +0000 To: Lancelot SIX Subject: Re: [PATCH 11/29] gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp Message-ID: <20220106093438.GE828155@redhat.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-12-lsix@lancelotsix.com> <20220104142625.GL1845520@redhat.com> <20220105220302.5t2jp5iqn4efhmp2@Plymouth> MIME-Version: 1.0 In-Reply-To: <20220105220302.5t2jp5iqn4efhmp2@Plymouth> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 09:34:18 up 4 days, 18:28, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Lancelot SIX [2022-01-05 22:03:21 +0000]: > > > > Did you consider using proc_with_prefix? You could change > > d32_set_tests and d64_set_tests like this: > > > > proc_with_prefix d32_set_tests {} { > > ... > > } > > > > proc_with_prefix d64_set_tests {} { > > ... > > } > > > > And this will cause all of the enclosed tests to be prefixed with > > 'd32_set_tests' or 'd64_set_tests'. This seems a slightly neater > > solution, what do you think? > > > > Thanks, > > Andrew > > Hi, > > I like your approach better. > > I have implemented it in the attached patch. > > Thanks, > Lancelot. > > --- > From 58a73a850f5b6f12e54d74b27ed3ef7ef96c9579 Mon Sep 17 00:00:00 2001 > From: Lancelot SIX > Date: Sat, 20 Nov 2021 00:10:07 +0000 > Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.base/dfp-test.exp > > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/dfp-test.exp ... > DUPLICATE: gdb.base/dfp-test.exp: 1.23E is an invalid number > DUPLICATE: gdb.base/dfp-test.exp: 1.23E45A is an invalid number > DUPLICATE: gdb.base/dfp-test.exp: 1.23E is an invalid number > DUPLICATE: gdb.base/dfp-test.exp: 1.23E45A is an invalid number > > Fix by using proc_with_prefix where appropriate. This LGTM. Thanks, Andrew > > Tested on x86_64-linux. > Co-Author-By: Andrew Burgess > --- > gdb/testsuite/gdb.base/dfp-test.exp | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/dfp-test.exp b/gdb/testsuite/gdb.base/dfp-test.exp > index e43ecd0e15e..4866d0ae094 100644 > --- a/gdb/testsuite/gdb.base/dfp-test.exp > +++ b/gdb/testsuite/gdb.base/dfp-test.exp > @@ -36,7 +36,7 @@ if ![runto_main] then { > > set sizeof_long [get_sizeof "long" 4] > > -proc d32_set_tests {} { > +proc_with_prefix d32_set_tests {} { > > gdb_test "p d32=123.45df" " = 123.45" > gdb_test "p d32=12345.df" " = 12345" > @@ -67,7 +67,7 @@ proc d32_set_tests {} { > gdb_test "p d32=1.23E45Adf" ".*Conversion syntax.*" "1.23E45A is an invalid number" > } > > -proc d64_set_tests {} { > +proc_with_prefix d64_set_tests {} { > > gdb_test "p d64=123.45dd" " = 123.45" > gdb_test "p d64=12345.dd" " = 12345" > @@ -97,7 +97,7 @@ proc d64_set_tests {} { > gdb_test "p d64=1.23E45Add" ".*Conversion syntax.*" "1.23E45A is an invalid number" > } > > -proc d128_set_tests {} { > +proc_with_prefix d128_set_tests {} { > > gdb_test "p d128=123.45dl" " = 123.45" > gdb_test "p d128=12345.dl" " = 12345" > -- > 2.34.1 >