From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GBvwJxFX1GFTJAAAWB0awg (envelope-from ) for ; Tue, 04 Jan 2022 09:17:53 -0500 Received: by simark.ca (Postfix, from userid 112) id A0DAC1F0DB; Tue, 4 Jan 2022 09:17:53 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 033111ECEB for ; Tue, 4 Jan 2022 09:17:53 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 78B753858432 for ; Tue, 4 Jan 2022 14:17:52 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 78B753858432 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641305872; bh=eYmvly53oubqWXDneiM85rOYwlVKPvsVEexNInH/u3A=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=sO+gdNBnhygFJXsmL2OTvT8DAXsJ8rxGBiXMM8hub5DIbu4bZS8hHesAD5MTdCcDh 1Vs869YWle7J7NPqb7NMTxRqjB3AqT8msVLd4uh49SNYap15EJR2gEseKn1XSCnecc r2v4VIpHb1bE9/0/822pUxiK4slMyH6dgBH2HQwY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 73905385842D for ; Tue, 4 Jan 2022 14:17:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 73905385842D Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-183-LxrUVpERNoOQ-NFBWzx-OQ-1; Tue, 04 Jan 2022 09:17:08 -0500 X-MC-Unique: LxrUVpERNoOQ-NFBWzx-OQ-1 Received: by mail-wm1-f69.google.com with SMTP id b83-20020a1c1b56000000b0033283ea5facso513087wmb.1 for ; Tue, 04 Jan 2022 06:17:07 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=CUpJ24LS5LUgM5+m7XCCA1ApEt6PWH8NuO/SXdpBCu8=; b=ji+VnsO9J3D5D4EshEHZLmKWRzjE75M45dFUmIrLRfG/EyBpazdwZIUuWsSWyRuV3b 5E8w2MLSmtYFADiBwoTgDCEa316ZdMh7XGk5Hq5akbImsDrBhS1bZg7RqQi2kesp4vlO VKlennUu8BYj4AzuJWXlkCdbfNfJ5Ww5EKMFA8I4KW2BbnkY7Db/dWPvGxcDtzOcOOPC P16DsFVhS0th1N7aaGzb3H6A3oMXcVDkmj70JXTauz3phOZ1bf2SVr3ILsRnSAo2fhuR iVcHSvPJk/abg7zEUoMrAe1AlTHRulWLgN7WTf22pqYubg4yZ+9aJZsbjsry7SHbKwje 4yfg== X-Gm-Message-State: AOAM530r3IoWNIsmLhDbFPYpdCJY0LBvEog6UxqNWgqLCIVECzPpAls/ AtG0OnovSGLSHsdif79CcZ85SJt9AYC/xzBRa2cr4HGteupcPjnKnw7qjpgTFcSKtrnYoDlIO5U BkYdBoVw/Ke3NyKAwU1Ij1g== X-Received: by 2002:adf:cc83:: with SMTP id p3mr42894602wrj.680.1641305826691; Tue, 04 Jan 2022 06:17:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJzpbSm+UHNEUcpfBvzGpCtEqXZglBa1+s+q5gAuKuCXXhl2+bnoPPF5zZPRA52NG84jB0N+3w== X-Received: by 2002:adf:cc83:: with SMTP id p3mr42894580wrj.680.1641305826480; Tue, 04 Jan 2022 06:17:06 -0800 (PST) Received: from localhost (host109-154-163-67.range109-154.btcentralplus.com. [109.154.163.67]) by smtp.gmail.com with ESMTPSA id o10sm28970858wmq.31.2022.01.04.06.17.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 06:17:06 -0800 (PST) Date: Tue, 4 Jan 2022 14:17:05 +0000 To: Lancelot SIX Subject: Re: [PATCH 09/29] gdb/testsuite: Remove duplicates from gdb.base/solib-display.exp Message-ID: <20220104141705.GJ1845520@redhat.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-10-lsix@lancelotsix.com> MIME-Version: 1.0 In-Reply-To: <20211121175636.779325-10-lsix@lancelotsix.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:16:51 up 2 days, 23:10, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Lancelot SIX via Gdb-patches [2021-11-21 17:= 56:16 +0000]: > When running the testsuite, I=A0have: >=20 > Running .../gdb/testsuite/gdb.base/solib-display.exp ... > DUPLICATE: gdb.base/solib-display.exp: NO: break 25 > DUPLICATE: gdb.base/solib-display.exp: NO: continue > DUPLICATE: gdb.base/solib-display.exp: IN: break 25 > DUPLICATE: gdb.base/solib-display.exp: IN: continue > DUPLICATE: gdb.base/solib-display.exp: SEP: break 25 > DUPLICATE: gdb.base/solib-display.exp: SEP: continue >=20 > The 'break 25' appears because the test inserts two breakpoints at the > same location. Fix this by only inserting the breakpoint once. >=20 > Fix the 'continue' DUPLICATE by giving a phony name to the second > continue: 'continue two'. >=20 > While at it, this commit also removes a trailing space. >=20 > Tested on x86_64-linux. LGTM. Thanks, Andrew > --- > gdb/testsuite/gdb.base/solib-display.exp | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) >=20 > diff --git a/gdb/testsuite/gdb.base/solib-display.exp b/gdb/testsuite/gdb= .base/solib-display.exp > index 54de334357f..f075b295899 100644 > --- a/gdb/testsuite/gdb.base/solib-display.exp > +++ b/gdb/testsuite/gdb.base/solib-display.exp > @@ -140,7 +140,7 @@ foreach libsepdebug {NO IN SEP} { with_test_prefix "$= libsepdebug" { > # are not cleared permaturely. > =20 > gdb_test "break [gdb_get_line_number "break here" ${testfile}.c]" \ > -=09 ".*Breakpoint.* at .*"=20 > +=09 ".*Breakpoint.* at .*" > =20 > gdb_test "continue" > gdb_test "display main_global" "4: main_global =3D 44" > @@ -153,11 +153,9 @@ foreach libsepdebug {NO IN SEP} { with_test_prefix "= $libsepdebug" { > } > =20 > gdb_test "" "6: a_static =3D 46\\r\\n4: main_global =3D 44\\r\\n.*" > - gdb_test "break [gdb_get_line_number "break here" ${testfile}.c]" \ > -=09 ".*Breakpoint.* at .*"=20 > gdb_test "continue" [multi_line \ > =09=09=09 "4: main_global =3D 44" \ > =09=09=09 "5: a_local =3D 45" \ > =09=09=09 "6: a_static =3D 46" \ > -=09=09=09 ] > +=09=09=09 ] "continue two" > }} > --=20 > 2.33.1 >=20