From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id AO6eOcFV1GEwJAAAWB0awg (envelope-from ) for ; Tue, 04 Jan 2022 09:12:17 -0500 Received: by simark.ca (Postfix, from userid 112) id CCAA01F0DB; Tue, 4 Jan 2022 09:12:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 913EA1ECEB for ; Tue, 4 Jan 2022 09:12:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0146B3858431 for ; Tue, 4 Jan 2022 14:12:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0146B3858431 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641305536; bh=CTZ0ZMBrIo3WsiKIleGMyQvYgbY822PIVgkVWxzcy1o=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=UBL4hvekPVmk1aDf1zHYW2UEYV0sfWvoRjK0lK81+U66suUDowwxKTBs1N1bDcTes 0uUr3097RgNQV5oEoi68lxLWo+DV/sIrOH5yJckGgrJLPHqKmHHoQKsBaAzc0bzpJP SDE6xK32y46aCKmRIyqdMfkQQQVI90N33tKzq5BY= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 32D023858406 for ; Tue, 4 Jan 2022 14:11:57 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 32D023858406 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-101-nPwJ32WRMuGRfj0S4XUMUg-1; Tue, 04 Jan 2022 09:11:55 -0500 X-MC-Unique: nPwJ32WRMuGRfj0S4XUMUg-1 Received: by mail-wr1-f71.google.com with SMTP id h12-20020adfa4cc000000b001a22dceda69so11743614wrb.16 for ; Tue, 04 Jan 2022 06:11:55 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=CTZ0ZMBrIo3WsiKIleGMyQvYgbY822PIVgkVWxzcy1o=; b=EnOHjl5NDDiK34LlGpq4Vie1XqpeCWYOJwIrEU/ndLRFHdGF/mj4hyNOXXq00jZTUC 0zDR/ztclaQ9zOgPhCsmYVqmL4+rbXc01Xho3IXWsCQxNyNfqaOCBWxpUtdaLUDImPGv dXQqb/PBMIEQMRNFpKMuUvHqDfONsAn3RSZRuk9q3vKXXpkTskF/2WHJSDYZkXT1PaGD Ocd27A4OoeQMJGcgHJ3+7Mpv6Ja9gtSBPVPSh6xiOC89czPJx8bHucmfH70udSDa0Nji +k1ixsbrqXoOQ9/yKw0j7NmqwdoWYYSy1QXZh3UwxjM7Cz+k819ny3TJe4yZG3sHrxzL ndqQ== X-Gm-Message-State: AOAM533n0yBAHIrt1tqqvnX5v+pYoT91sXiJFhH5qcXcWz8wV/nTRqcs XIydClOwe8MLWt3WeT1Z15yxpXVyPYxEzREn+BbmZ42S7Jki47legmUEo6QyQtcMrzNSg5dIl5e xmaNwpijboRuqzJfZf9/yew== X-Received: by 2002:a05:6000:1569:: with SMTP id 9mr42289822wrz.127.1641305514356; Tue, 04 Jan 2022 06:11:54 -0800 (PST) X-Google-Smtp-Source: ABdhPJzn1/eu7Y/ux8hnSBqpbolh2hcpOTMYVciqU0xlKTxJ+tB/+izlLw/45uMK5ioTP4YVDMYveg== X-Received: by 2002:a05:6000:1569:: with SMTP id 9mr42289810wrz.127.1641305514166; Tue, 04 Jan 2022 06:11:54 -0800 (PST) Received: from localhost (host109-154-163-67.range109-154.btcentralplus.com. [109.154.163.67]) by smtp.gmail.com with ESMTPSA id b5sm8005100wrr.19.2022.01.04.06.11.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 06:11:53 -0800 (PST) Date: Tue, 4 Jan 2022 14:11:53 +0000 To: Lancelot SIX Subject: Re: [PATCH 06/29] gdb/testsuite: Remove duplicates from gdb.base/checkpoint.exp Message-ID: <20220104141153.GG1845520@redhat.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-7-lsix@lancelotsix.com> MIME-Version: 1.0 In-Reply-To: <20211121175636.779325-7-lsix@lancelotsix.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:11:42 up 2 days, 23:05, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Lancelot SIX via Gdb-patches [2021-11-21 17:56:13 +0000]: > When running the testsuite, I have: > > Running .../gdb/testsuite/gdb.base/checkpoint.exp ... > DUPLICATE: gdb.base/checkpoint.exp: verify lines 5 two > DUPLICATE: gdb.base/checkpoint.exp: restart 0 one > > This patch fixes the various erroneous incorrect test names. > > While at it, this patch also remove some trailing white spaces across > the file. > > Tested on x86_64-linux. LGTM. Thanks, Andrew > --- > gdb/testsuite/gdb.base/checkpoint.exp | 22 +++++++++++----------- > 1 file changed, 11 insertions(+), 11 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/checkpoint.exp b/gdb/testsuite/gdb.base/checkpoint.exp > index 46042a9f345..6a1ec22aee3 100644 > --- a/gdb/testsuite/gdb.base/checkpoint.exp > +++ b/gdb/testsuite/gdb.base/checkpoint.exp > @@ -65,7 +65,7 @@ gdb_test "checkpoint" ".*" "" > gdb_test "continue 10" "breakpoint 1.*" "break1 three" > > gdb_test "checkpoint" ".*" "" > -gdb_test "continue 10" "breakpoint 1.*" "break1 four" > +gdb_test "continue 10" "breakpoint 1.*" "break1 four" > > gdb_test "checkpoint" ".*" "" > gdb_test "continue 10" "breakpoint 1.*" "break1 five" > @@ -146,7 +146,7 @@ gdb_test "print i + 1 == lines * 79" " = 1" "verify i 10 one" > gdb_test "print lines" " = 91.*" "verify lines 10 one" > > # > -# Now let the files be closed by the original process, > +# Now let the files be closed by the original process, > # and diff them. > > gdb_test "restart 0" "Switching to .*breakpoint 2.*" "restart 0 one" > @@ -158,7 +158,7 @@ gdb_test "shell diff -s $pi_txt $copy1_txt" \ > "diff input and output one" > > # > -# And now run from various checkpoints, allowing > +# And now run from various checkpoints, allowing > # various amounts of input and output. > # > > @@ -198,7 +198,7 @@ gdb_test "restart 6" "Switching to .*c == EOF.*" "restart 6 two" > gdb_test "continue" ".*" "" > gdb_test "continue 1000" "breakpoint 1.*" "breakpoint 1 6 one" > gdb_test "step" "if .c == EOF.*" "step in 6 two" > -gdb_test "print lines" " = 1052.*" "verify lines 5 two" > +gdb_test "print lines" " = 1052.*" "verify lines 6 two" > > gdb_test "restart 7" "Switching to .*c == EOF.*" "restart 7 two" > gdb_test "continue" ".*" "" > @@ -210,12 +210,12 @@ gdb_test "shell diff -s $pi_txt $copy1_txt" \ > "Files .*pi.txt and .*copy1.txt are identical.*" \ > "diff input and output two" > > -# > -# OK, now allow the original program to delete the output file, > +# > +# OK, now allow the original program to delete the output file, > # and verify that the checkpoints can still write to it. > -# > +# > > -gdb_test "restart 0" "Switching to .*breakpoint 3.*" "restart 0 one" > +gdb_test "restart 0" "Switching to .*breakpoint 3.*" "restart 0 two" > gdb_breakpoint $break4_loc > gdb_test "continue" "breakpoint 4.*" "break4 one" > > @@ -259,7 +259,7 @@ gdb_test "continue" \ > > # > # There should be still at least five forks left > -# > +# > > gdb_test "info checkpoints" " 1 .* 2 .* 3 .* 4 .* 5 .*" \ > "info checkpoints two" > @@ -271,7 +271,7 @@ gdb_test "info checkpoints" " 1 .* 2 .* 3 .* 4 .* 5 .*" \ > gdb_test "kill" "" "kill all one" \ > "Kill the program being debugged.*y or n. $" "y" > > -# > +# > # and confirm that all are gone > # > > @@ -324,7 +324,7 @@ gdb_test_multiple "info checkpoints" $msg { > fail $msg > } > } > -} > +} > > # > # OK, kill 'em all... > -- > 2.33.1 >