From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id E9LBButS1GF8IwAAWB0awg (envelope-from ) for ; Tue, 04 Jan 2022 09:00:11 -0500 Received: by simark.ca (Postfix, from userid 112) id 08DCA1F0DB; Tue, 4 Jan 2022 09:00:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7DCD41ECEB for ; Tue, 4 Jan 2022 09:00:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A1E073858406 for ; Tue, 4 Jan 2022 14:00:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A1E073858406 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1641304809; bh=I1ybCNYAC+ZbOsXAW88v2uTi55SHVxds9aIbS1KCdmc=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=FZHpygONbFFxE87fEVtepezl8AWEeB4hYRAvZWi5vFBk3NAZIEl3lOECHp78Nigak ByJ9BcuIsTs3QOMit4FuRlOUPSRLrkfa0m4z8vgZW2otH8boi0ZGSH3MDMuhamab77 BlQiUlwiUgGwTJzFhoBfJO+Cj3kVC4xoFndgjZ0A= Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 28EB83858431 for ; Tue, 4 Jan 2022 13:59:38 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28EB83858431 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-517-CuuuZZOQNKyAClNf3qMQrA-1; Tue, 04 Jan 2022 08:59:36 -0500 X-MC-Unique: CuuuZZOQNKyAClNf3qMQrA-1 Received: by mail-wm1-f71.google.com with SMTP id d4-20020a05600c34c400b00345d5d47d54so329808wmq.6 for ; Tue, 04 Jan 2022 05:59:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=x2jTX25WBHYodkgVEhNlpTgtItupyTx+zcXoQYbxlrE=; b=5kaHLco5881/TeYTwgT5CFHg2c68t+Gnp4G4yeWMQhxYP4tOw0ZoaXwmdLmRMfsOCH er9vUjhnRYj7mrn1eErgNEE0oIMu5b33O/tXV9XPF+V4/Szoq0FpRZ/7WwwnmwVpPA4w Iwzb9F+IFu/Y0uXlP3pJpSkQyH6p7aCyb5hg13FgNuGXccnbhUjMCu1BghZc9mqlJQb0 gycW6IImYuZP+vq0Dd99KphNbiVEkQZ9z5pR/YeY6Tn7P5gMtqWUmefaDRIO7+EGVIoY 36V1FYscJ9DFT2wpauetV+958U8GQ28vejLFVpQhacMBxc3wDJ6610C01k95PXs7I2xz O2ZA== X-Gm-Message-State: AOAM5331zHhwXb027ZvidK6yDEt5dBkZ4FA2QJpDinyv16YJWWbmJAcD XH4q2PeickDn4zXZ9sz1lWUMtS6mdPm9Sz0crS2dfmAfPyw4EgZuZ8zIBiNs5J1K0ghfio2EZtZ FyW3iWYbwmzmZ++5BEWijow== X-Received: by 2002:adf:eb87:: with SMTP id t7mr35651425wrn.147.1641304775132; Tue, 04 Jan 2022 05:59:35 -0800 (PST) X-Google-Smtp-Source: ABdhPJwwzgFgD7U7F7mCTTWrF5wfHGfPvg+ah+owdfgLsxu+P/tJisLoMwchz+SsPCmjwoKjsrShvg== X-Received: by 2002:adf:eb87:: with SMTP id t7mr35651415wrn.147.1641304774941; Tue, 04 Jan 2022 05:59:34 -0800 (PST) Received: from localhost (host109-154-163-67.range109-154.btcentralplus.com. [109.154.163.67]) by smtp.gmail.com with ESMTPSA id g12sm42468186wrd.71.2022.01.04.05.59.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 04 Jan 2022 05:59:34 -0800 (PST) Date: Tue, 4 Jan 2022 13:59:33 +0000 To: Lancelot SIX Subject: Re: [PATCH 01/29] gdb/testsuite: Remove duplicates from gdb.base/stack-checking.exp Message-ID: <20220104135933.GC1845520@redhat.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-2-lsix@lancelotsix.com> MIME-Version: 1.0 In-Reply-To: <20211121175636.779325-2-lsix@lancelotsix.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:55:18 up 2 days, 22:49, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Andrew Burgess via Gdb-patches Reply-To: Andrew Burgess Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Lancelot SIX via Gdb-patches [2021-11-21 17:= 56:08 +0000]: > When running the testsuite I=A0have: >=20 > Running .../gdb/testsuite/gdb.base/stack-checking.exp ... > DUPLICATE: gdb.base/stack-checking.exp: bt > DUPLICATE: gdb.base/stack-checking.exp: bt >=20 > Fix by using with_test_prefix. >=20 > Tested on x86_64-linux. > --- > gdb/testsuite/gdb.base/stack-checking.exp | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) >=20 > diff --git a/gdb/testsuite/gdb.base/stack-checking.exp b/gdb/testsuite/gd= b.base/stack-checking.exp > index ca66617009f..634e4be2e6b 100644 > --- a/gdb/testsuite/gdb.base/stack-checking.exp > +++ b/gdb/testsuite/gdb.base/stack-checking.exp > @@ -31,8 +31,10 @@ if ![runto_main] then { > # Test that the debugger is able to unwind to "main" at the next breakpo= int > # hit. The frame number of "main" should be passed into MAIN_FRAME_NUMBE= R." > proc backtrace_test {name main_frame_number} { > - gdb_continue_to_breakpoint "breakpoint for $name" > - gdb_test "bt" "#${main_frame_number}.*in main ().*" > + with_test_prefix $name { > +=09gdb_continue_to_breakpoint "breakpoint for $name" This looks good. I think you should change the test name used in gdb_continue_to_breakpoint though, as we're now repeating ourselves. I'd go with something like: gdb_continue_to_breakpoint "test location" or something similar. This is good to merge with that change. Thanks, Andrew > +=09gdb_test "bt" "#${main_frame_number}.*in main ().*" > + } > } > =20 > gdb_breakpoint [gdb_get_line_number "set breakpoint here"] > --=20 > 2.33.1 >=20