From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hsggLlYcvWGmIQAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 18:25:10 -0500 Received: by simark.ca (Postfix, from userid 112) id AB67B1F0CE; Fri, 17 Dec 2021 18:25:10 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 47E261E940 for ; Fri, 17 Dec 2021 18:25:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 90638385802D for ; Fri, 17 Dec 2021 23:25:09 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 90638385802D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639783509; bh=NkWU6P72rdlZ6L5v9eKvWK7UFijC3mbq1DZp1/4iIgs=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CM8j8fVojt6gy/yDiHmvSufu11+yOwt/70W0+K0/PYDLVgoG+1lsuLaKD/pZfPqpF nUXRwEcnnceZ5MKUK7SfgF0gg1QVR8Nh/A0M80Cb22X7Senwdg5l13Rd0vPfgEfoia CFrhhHIv0JoW6/Fn2+V/wcHon6s4Qcwx41sUOmFk= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id B51F13858433 for ; Fri, 17 Dec 2021 23:24:43 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B51F13858433 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:413a:a3d0:a542:d809]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id D94F980D5D; Fri, 17 Dec 2021 23:24:42 +0000 (UTC) Date: Fri, 17 Dec 2021 23:24:39 +0000 To: Pedro Alves Subject: Re: [PATCH] gdb/testsuite: Remove some duplication from gdb.mi/mi-var-child.exp Message-ID: <20211217232439.urx6zd2egmwntmje@Plymouth> References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-6-lsix@lancelotsix.com> <20211216234049.zendtecxswjceyki@Plymouth> <55e612b6-645a-b044-da7c-a2ee48298de0@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <55e612b6-645a-b044-da7c-a2ee48298de0@palves.net> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 17 Dec 2021 23:24:42 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > That is certainly fine. Please go ahead with what you had. > > I gave it another look, and noticed that at least the "get number of children" tests > can be easily factored out, like below. This applies on top of your patch. > > WDYT? > Nice! I was expecting something similar could be done, but I did not pushed to do it. It looks good, and I confirm that I have no difference in the .sum file. I am confident this is OK, and I have integrated this patch in my branch. If this is OK, I'll push with the rest of my series. Thanks, Lancelot.