From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id tqcNOtwZvWFkIQAAWB0awg (envelope-from ) for ; Fri, 17 Dec 2021 18:14:36 -0500 Received: by simark.ca (Postfix, from userid 112) id DD76B1F0CE; Fri, 17 Dec 2021 18:14:36 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1A5C81E940 for ; Fri, 17 Dec 2021 18:14:36 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8FE8C3858423 for ; Fri, 17 Dec 2021 23:14:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8FE8C3858423 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639782875; bh=Dmvn9MefvtUoH/O74hFo74uV77/KdPbJmC4aJOKHgvA=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=NiykYBQlVZjpHStCUpIA8vYgz5M8ndbKkXUNObj1lIPQExvj5qgJh1eB1ixKhpn3X G3zPz/cxzv66fdKQ0lyGMggQmDTxTNvzDZ0K22MNtlsaSe8SaNk25dG6yvLQWCf4ba w600pv9/gNIO5NvnHTrcMWwO8sC+JTxOv0ZcG1PU= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 5455E3858407 for ; Fri, 17 Dec 2021 23:14:17 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5455E3858407 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:413a:a3d0:a542:d809]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 5C97980D5D; Fri, 17 Dec 2021 23:14:16 +0000 (UTC) Date: Fri, 17 Dec 2021 23:14:13 +0000 To: Pedro Alves Subject: Re: [PATCH 25/29] gdb/testsuite: Remove duplicates from gdb.base/pointers.exp Message-ID: <20211217231413.irtot7vgpbccf7j2@Plymouth> References: <20211121175636.779325-1-lsix@lancelotsix.com> <20211121175636.779325-26-lsix@lancelotsix.com> <1fbd61ac-abbb-16d1-3f14-400d05dc20d5@palves.net> <20211216231414.kgin6p7nndajxpuk@Plymouth> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 17 Dec 2021 23:14:16 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > > Hmm, how about this instead? > > with_test_prefix "post-increment" { > gdb_test_no_output "set variable y = *v_int_pointer++" \ > "pointer dereference, set variable" > gdb_test "print y" " = 6" "pointer assignment" > gdb_test "print *v_int_pointer" " = 18" "pointer increment" > } > > with_test_prefix "pre-decrement" { > gdb_test_no_output "set variable y = *--v_int_pointer2" \ > "pointer dereference, set variable" > gdb_test "print y" " = 6" "pointer assignment" > gdb_test "print *v_int_pointer2" " = 6" "pointer decrement" > } Done in the wollowing patch. Lancelot. --- >From 08d05cebf6b40b64834d1d2a140ca6a9a99be8ae Mon Sep 17 00:00:00 2001 From: Lancelot SIX Date: Sun, 21 Nov 2021 01:55:43 +0000 Subject: [PATCH] gdb/testsuite: Remove duplicates from gdb.base/pointers.exp MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit When I run the testsuite, I have : Running .../gdb/testsuite/gdb.base/pointers.exp ... DUPLICATE: gdb.base/pointers.exp: pointer assignment Fix by placing the sections with duplication in with_test_prefix blocks. This removes the duplication and gives a better organization the file. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/pointers.exp | 22 ++++++++++++---------- 1 file changed, 12 insertions(+), 10 deletions(-) diff --git a/gdb/testsuite/gdb.base/pointers.exp b/gdb/testsuite/gdb.base/pointers.exp index fa7531d0f85..0ac0465072f 100644 --- a/gdb/testsuite/gdb.base/pointers.exp +++ b/gdb/testsuite/gdb.base/pointers.exp @@ -145,18 +145,20 @@ gdb_test "print v_int_pointer < v_int_pointer2" " = $true" \ gdb_test "print v_int_pointer > v_int_pointer2" " = $false" \ "pointer1>pointer2" -gdb_test_no_output "set variable y = *v_int_pointer++" \ - "set y = *v_int_pointer++" -gdb_test "print y" " = 6" "pointer assignment" -gdb_test "print *v_int_pointer" " = 18" "and post-increment" - - +with_test_prefix "post-increment" { + gdb_test_no_output "set variable y = *v_int_pointer++" \ + "set y = *v_int_pointer++" + gdb_test "print y" " = 6" "pointer assignment" + gdb_test "print *v_int_pointer" " = 18" "and post-increment" +} -gdb_test_no_output "set variable y = *--v_int_pointer2" \ - "set y = *--v_int_pointer2" -gdb_test "print y" " = 6" "pointer assignment" -gdb_test "print *v_int_pointer2" " = 6" "and pre-decrement" +with_test_prefix "pre-decrement" { + gdb_test_no_output "set variable y = *--v_int_pointer2" \ + "set y = *--v_int_pointer2" + gdb_test "print y" " = 6" "pointer assignment" + gdb_test "print *v_int_pointer2" " = 6" "and pre-decrement" +} gdb_test_no_output "set variable y =v_int_pointer-v_int_pointer2" \ -- 2.34.0