From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7K48OZ/Ou2EIbwAAWB0awg (envelope-from ) for ; Thu, 16 Dec 2021 18:41:19 -0500 Received: by simark.ca (Postfix, from userid 112) id D78C01F0BD; Thu, 16 Dec 2021 18:41:19 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6B4631ECEB for ; Thu, 16 Dec 2021 18:41:19 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id ACBF9385841C for ; Thu, 16 Dec 2021 23:41:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ACBF9385841C DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639698078; bh=ygHDnpRh5czuqBf3sv3hz0jBs+W4TvCGZ28TwuaUAK0=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=pLJWY7OA6ZDBH3i9nQsNeuQ9uk7rD2g6Aqy3edTL2pEn1dUT+9c0p0eoYW+30WUt9 qjtZcafGnkjwJz8vLJcPtnv6hdAy5WixHWSMUbFECzFZ2lOoOcA6i4YQ0KD6rzOAqE V5YrYXCpu4BcR3nIAWmWnZjQ5myFYxhgXbr2c28g= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 41E1D3858D35 for ; Thu, 16 Dec 2021 23:40:55 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 41E1D3858D35 Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:7c27:fcf5:8e6d:c1bd]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 7158880D5D; Thu, 16 Dec 2021 23:40:54 +0000 (UTC) Date: Thu, 16 Dec 2021 23:40:49 +0000 To: Pedro Alves Subject: Re: [PATCH 05/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-child.exp Message-ID: <20211216234049.zendtecxswjceyki@Plymouth> References: <20211126230038.103225-1-lsix@lancelotsix.com> <20211126230038.103225-6-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 16 Dec 2021 23:40:54 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > > Did you consider using variables to eliminate risk of these ever diverging? Something like: > > set expr "psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr.****char_ptr" > mi_gdb_test "-var-info-num-children $expr" \ > "\\^done,numchild=\"0\"" \ > "get number of children of $expr" > > ... Actually, not that much. This file is 1k+ lines with plenty of tests just like this one. Do not get me wrong, doing this would be a big plus, but given the extend of changes I would think it is a bit out of the scope of what I want to achieve. Do you mind if I postpone this refactoring? i.e. I get it out of my mind until next time I have to come back to this file, or want to spend time just doing this. Lancelot.