From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +0qaD4kMsmExKgAAWB0awg (envelope-from ) for ; Thu, 09 Dec 2021 09:02:49 -0500 Received: by simark.ca (Postfix, from userid 112) id 2FBA01F0CE; Thu, 9 Dec 2021 09:02:49 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B67961EDEE for ; Thu, 9 Dec 2021 09:02:48 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 01939385800D for ; Thu, 9 Dec 2021 14:02:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 01939385800D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1639058568; bh=Z/ZRT9bnBSFiprXqfGIlmp1HdULRihgPqLCOqFFCQbs=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:Cc:From; b=g7mJquOAmqwmX/c6xmQcZLfOHrGV58+Nu5Lwx91NY16cjq/c5o2JM+pQw+k4qhUVY pH0utxF0Av8KLdIo0N+oTeQA9RGB1cnX9nemahkSD9RldJM+29aUl+B3XFUG8womeD f8zFXEtElgYfc/NmKsUfmpUsI3iVl2u+uXUoastY= Received: from mail-io1-xd33.google.com (mail-io1-xd33.google.com [IPv6:2607:f8b0:4864:20::d33]) by sourceware.org (Postfix) with ESMTPS id 810B63858402 for ; Thu, 9 Dec 2021 14:02:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 810B63858402 Received: by mail-io1-xd33.google.com with SMTP id z26so6642035iod.10 for ; Thu, 09 Dec 2021 06:02:29 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Z/ZRT9bnBSFiprXqfGIlmp1HdULRihgPqLCOqFFCQbs=; b=tQ0NUaaqBRtG1JDVtXISEUemxDWD9BbPctseUOHVAGNl6deeWgPpTuGSg1NnYFHphT NwWaEOyBopZFEstJ0ndZ/+Fb7VW88qkb+uHFLdbRrK5ElbE3PrO18vHY54hBu+YW71rI U3pdDqvPviBZZ1FnP/dO4w0qLh6drbDzo0NQxswi7Tm4eiZO7CE+XlO3qJJzodsuT30q 4uXnn7Qt3HPIR56tjD/rAT9/nJzJQH8y5T2GaG++3P7ym85CJomoTGWWYAk3YIBggCdd xXnFsb/7KLmyld+2bmS0YfoggdoACHnnEWxbPdjKCRgxt9RKrra98NEO7EvVM6r6TbRM srEQ== X-Gm-Message-State: AOAM532AUtTGd5sVKb1BC6k9IhLVksBUiue6TxywykCmdoSbONCAO0yQ lVLIqhJIg6z4e2/UJJDKrXQRKBUYcw/YuA== X-Google-Smtp-Source: ABdhPJxRzI4A6+MKJhiu+eCUVWFFiB1tkW2dqES5pc1X9IqTC5zbkKNAJ3ZxiJz9EALSQ89EArE5Jw== X-Received: by 2002:a05:6638:2684:: with SMTP id o4mr9106850jat.70.1639058548875; Thu, 09 Dec 2021 06:02:28 -0800 (PST) Received: from murgatroyd.Home (97-122-84-67.hlrn.qwest.net. [97.122.84.67]) by smtp.gmail.com with ESMTPSA id i20sm4150795iow.9.2021.12.09.06.02.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 09 Dec 2021 06:02:28 -0800 (PST) To: gdb-patches@sourceware.org Subject: [PATCH] Fix ARM simulator build on Windows Date: Thu, 9 Dec 2021 07:02:12 -0700 Message-Id: <20211209140212.3980587-1-tromey@adacore.com> X-Mailer: git-send-email 2.31.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom Tromey via Gdb-patches Reply-To: Tom Tromey Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" For a Windows-hosted build with arm-elf as the target, the sim build fails like: [...]sim-io.c:214:29: error: 'struct host_callback_struct' has no member named 'open' The recent header reorganization seems to have caused this, because now 'open' is redefined by the gnulib fcntl.h. The fix is simple: remove the undef of 'open' from sim-io.c. --- sim/common/sim-io.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sim/common/sim-io.c b/sim/common/sim-io.c index 8c40f7a0e73..8cc078c3cd2 100644 --- a/sim/common/sim-io.c +++ b/sim/common/sim-io.c @@ -37,8 +37,6 @@ #include "sim-io.h" #include "sim/callback.h" -#undef open - /* Define the rate at which the simulator should poll the host for a quit. */ #ifndef POLL_QUIT_INTERVAL -- 2.31.1