From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CAyNIqdnoWE6QAAAWB0awg (envelope-from ) for ; Fri, 26 Nov 2021 18:03:03 -0500 Received: by simark.ca (Postfix, from userid 112) id 8A92E1F0CE; Fri, 26 Nov 2021 18:03:03 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 01A341EDF0 for ; Fri, 26 Nov 2021 18:03:03 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9AAAE3857C5E for ; Fri, 26 Nov 2021 23:03:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 9AAAE3857C5E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637967782; bh=A0Pkba9Yb71nYYHYXDAJe5sjfCs6GdTJVFPVwpKYNSk=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=yu45rDtOP8u6QTC+C0vlL9neEfiaj5WJrkFXhFWJg+1Esoj17sZNaA1urQAz1PAZG p/IXM7ln5pvy7fSZa9MxOpZIAn21/A/+79LnmHIPhmbthTV9AWQlbljxYnCsYSsQCt sux8orVmWSycZRVwqtN3WWd5Q2zFQ8aCt2h+DAVk= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 0D7FB3858C3A for ; Fri, 26 Nov 2021 23:01:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 0D7FB3858C3A Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:a47d:3441:84f3:f4bc]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 316AC85740; Fri, 26 Nov 2021 23:00:59 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 05/12] gdb/testsuite: Remove duplicates from gdb.mi/mi-var-child.exp Date: Fri, 26 Nov 2021 23:00:31 +0000 Message-Id: <20211126230038.103225-6-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211126230038.103225-1-lsix@lancelotsix.com> References: <20211126230038.103225-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 26 Nov 2021 23:00:59 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite, I have: Running .../gdb/testsuite/gdb.mi/mi-var-child.exp ... DUPLICATE: gdb.mi/mi-var-child.exp: get children of psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr.***psnp->char_ptr DUPLICATE: gdb.mi/mi-var-child.exp: get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr DUPLICATE: gdb.mi/mi-var-child.exp: get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr DUPLICATE: gdb.mi/mi-var-child.exp: get number of children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr This testfile gives test names in comments, which are different from the test names given to the test framework (the former gives a number to each test while the latter describes what is tested), I'll use the test names from the comment when describing the fixes below are they are easier to reason about. The tests c_variable-5.15B and c_variable-5.17 are identical, so drop c_variable-5.15B. The descriptive name of c_variable-5.41B is erroneous, and once it have been fixed it turns out that this test is identical to c_variable-5.43, therefore c_variable-5.41B is dropped as well. The descriptive test names for c_variable-5.43B c_variable-5.44B are erroneous, so fix them. The above adjustments fix the DUPLICATEs warnings. Tested on x86_64-linux. --- gdb/testsuite/gdb.mi/mi-var-child.exp | 18 ++---------------- 1 file changed, 2 insertions(+), 16 deletions(-) diff --git a/gdb/testsuite/gdb.mi/mi-var-child.exp b/gdb/testsuite/gdb.mi/mi-var-child.exp index 63cea065c3f..cec433a4c8c 100644 --- a/gdb/testsuite/gdb.mi/mi-var-child.exp +++ b/gdb/testsuite/gdb.mi/mi-var-child.exp @@ -881,13 +881,6 @@ mi_list_varobj_children "psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr" { {\*\*\*psnp->char_ptr} 1 {char \*}} } "get children of psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr" -# Test: c_variable-5.15B -# Desc: children of *(*(*(psnp->char_ptr))) -mi_list_varobj_children "psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr.***psnp->char_ptr" { - {{psnp->char_ptr.\*psnp->char_ptr.\*\*psnp->char_ptr.\*\*\*psnp->char_ptr.\*\*\*\*psnp->char_ptr} \ - {\*\*\*\*psnp->char_ptr} 0 char} -} "get children of psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr.***psnp->char_ptr" - # Test: c_variable-5.16 # Desc: number of children of *(*(psnp->char_ptr)) mi_gdb_test "-var-info-num-children psnp->char_ptr.*psnp->char_ptr.**psnp->char_ptr" \ @@ -1072,13 +1065,6 @@ mi_list_varobj_children "psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr" { {\*\*\*char_ptr} 1 {char \*}} } "get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr" -# Test: c_variable-5.41B -# Desc: children of ***psnp->ptrs[0]->next->char_ptr -mi_list_varobj_children "psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr" { - {{psnp->ptrs.0.next.char_ptr.\*char_ptr.\*\*char_ptr.\*\*\*char_ptr.\*\*\*\*char_ptr} \ - {\*\*\*\*char_ptr} 0 char} -} "get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr" - # Test: c_variable-5.42 # Desc: number of children of **psnp->ptrs[0]->next->char_ptr mi_gdb_test "-var-info-num-children psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr" \ @@ -1101,13 +1087,13 @@ mi_gdb_test "-var-info-num-children psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ # Test: c_variable-5.43B # Desc: children of ****psnp->ptrs[0]->next->char_ptr mi_list_varobj_children "psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr.****char_ptr" {} \ - "get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr" + "get children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr.****char_ptr" # Test: c_variable-5.44B # Desc: number of children of ****psnp->ptrs[0]->next->char_ptr mi_gdb_test "-var-info-num-children psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr.****char_ptr" \ "\\^done,numchild=\"0\"" \ - "get number of children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr" + "get number of children of psnp->ptrs.0.next.char_ptr.*char_ptr.**char_ptr.***char_ptr.****char_ptr" # Test: c_variable-5.45 # Desc: children of psnp->ptrs[0]->next->next -- 2.33.1