From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SOltKWZooWE6QAAAWB0awg (envelope-from ) for ; Fri, 26 Nov 2021 18:06:14 -0500 Received: by simark.ca (Postfix, from userid 112) id A6D251F0CE; Fri, 26 Nov 2021 18:06:14 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 476361EDF0 for ; Fri, 26 Nov 2021 18:06:14 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id D5FF53857C4F for ; Fri, 26 Nov 2021 23:06:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org D5FF53857C4F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637967973; bh=4boxQQySqBDifXEAapEKrdFDnN/CwYxHYpgTn+04/UU=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=XWYudMZFOmOOAWwauMaMGk4p6Bb0aBZDhrFH6dkNCKCkuhfZpXxnP+yb0b6RgV9Ox NwilcHa+/fzVkfpFnFKUAsB+h03iweAGaeaZN0+VWq9DCBiCmuvPSxsiLg1Lif4Gu2 yUnCTGGoOoW6IX2xbwduNFQguw1VKvz0u5wrmyac= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 7807C385780F for ; Fri, 26 Nov 2021 23:01:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7807C385780F Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:a47d:3441:84f3:f4bc]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 7AA1F85747; Fri, 26 Nov 2021 23:01:00 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 12/12] gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex Date: Fri, 26 Nov 2021 23:00:38 +0000 Message-Id: <20211126230038.103225-13-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211126230038.103225-1-lsix@lancelotsix.com> References: <20211126230038.103225-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 26 Nov 2021 23:01:00 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite, I have: Running .../gdb/testsuite/gdb.threads/staticthreads.exp ... DUPLICATE: gdb.threads/staticthreads.exp: couldn't compile staticthreads.c: unrecognized error Fix by using foreach_with_prefix instead of foreach when preparing the test case. Testeed on x86_64-linux both in a setup where the test fails to prepare and in a setup where the test fails to setup. --- gdb/testsuite/gdb.threads/staticthreads.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.threads/staticthreads.exp b/gdb/testsuite/gdb.threads/staticthreads.exp index e80405426e0..37530c68e39 100644 --- a/gdb/testsuite/gdb.threads/staticthreads.exp +++ b/gdb/testsuite/gdb.threads/staticthreads.exp @@ -22,7 +22,7 @@ standard_testfile set static_flag "-static" -foreach have_tls { "-DHAVE_TLS" "" } { +foreach_with_prefix have_tls { "-DHAVE_TLS" "" } { if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \ executable \ [list debug "additional_flags=${static_flag} ${have_tls}" \ -- 2.33.1