From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +Mh4NOWImmEyUQAAWB0awg (envelope-from ) for ; Sun, 21 Nov 2021 12:59:01 -0500 Received: by simark.ca (Postfix, from userid 112) id D44411F0CE; Sun, 21 Nov 2021 12:59:01 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6EE171EDF0 for ; Sun, 21 Nov 2021 12:59:01 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 136A23858001 for ; Sun, 21 Nov 2021 17:59:01 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 136A23858001 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637517541; bh=lB2nHS5MuZka38SDdNzE250SAc4PerU5HR5EaUOwXL0=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=DE2mpy1C+2FvvD//nnttFPLKDPr+rtbPorzH/WbHYRhLCiNhu5RRZ25Ro7oGCIcR9 hGadXE9r6OOyzwhx586FUXvE1rv/wYCMgPZxy1woXBVZnlz+V1oH1iBZE6B0x0WgBs z3GM2enQS78/vrQKeoEWGcJS1mSv8ro6N5ycRuAc= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id 862F7385843F for ; Sun, 21 Nov 2021 17:57:24 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 862F7385843F Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:e409:90b0:99cc:9f98]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 71D308198D; Sun, 21 Nov 2021 17:57:22 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 03/29] gdb/testsuite: Remove duplicates from gdb.base/interp.exp Date: Sun, 21 Nov 2021 17:56:10 +0000 Message-Id: <20211121175636.779325-4-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Sun, 21 Nov 2021 17:57:23 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite I have: Running .../gdb/testsuite/gdb.base/interp.exp ... DUPLICATE: gdb.base/interp.exp: interpreter-exec mi "-var-update *" This is due to the fact that two successive instances of gdb_test_multiple use 'pass $cmd', but the second test forgets to reset $cmd. Fix by updating the value of cmd where appropriate. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/interp.exp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/interp.exp b/gdb/testsuite/gdb.base/interp.exp index fc95ee113c2..3d28232c522 100644 --- a/gdb/testsuite/gdb.base/interp.exp +++ b/gdb/testsuite/gdb.base/interp.exp @@ -34,8 +34,8 @@ gdb_test_multiple $cmd $cmd { gdb_test "interpreter-exec console \"show version\"" "GNU gdb .*" # Regression test for crash when an exception occurs in mi_parse. -gdb_test_multiple "interpreter-exec mi \"-break-insert --thread a\"" \ - "regression test for mi_parse crash" { +set cmd "interpreter-exec mi \"-break-insert --thread a\"" +gdb_test_multiple $cmd "regression test for mi_parse crash" { -re ".error,msg=.Invalid value for the '--thread' option.\r\n$gdb_prompt " { pass "$cmd" gdb_expect 1 { -- 2.33.1