From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ED7IIKKLmmEyUQAAWB0awg (envelope-from ) for ; Sun, 21 Nov 2021 13:10:42 -0500 Received: by simark.ca (Postfix, from userid 112) id 842A51F0CE; Sun, 21 Nov 2021 13:10:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 134351EDF0 for ; Sun, 21 Nov 2021 13:10:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id AD1A1385841F for ; Sun, 21 Nov 2021 18:10:41 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AD1A1385841F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637518241; bh=DF2xb+/PAaBuugKw5YDxceq2dF6w7HmL3EMl3Pccvrc=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=ISYozgwgVFI5IC0pu0WNf6YFXJmQdeIkj11CMWraz58u4zEeXjhVCXKcdZFVnp8U7 TjOdvMB4O0U6or1HhB2dD7FWuar41ZWpIDEXDG2NSanhXSaEj7joSE1AJvOxVksfI6 PI1N6/lDIu7PbrKzGixQw0X8/OrPpohDec+yNZZU= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 2CC77385843F for ; Sun, 21 Nov 2021 17:58:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 2CC77385843F Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:e409:90b0:99cc:9f98]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 12601854F8; Sun, 21 Nov 2021 17:58:04 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 29/29] gdb/testsuite: Remove duplicates from gdb.base/corefile-buildid.exp Date: Sun, 21 Nov 2021 17:56:36 +0000 Message-Id: <20211121175636.779325-30-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Sun, 21 Nov 2021 17:58:06 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite, I have: Running .../gdb/testsuite/gdb.base/corefile-buildid.exp ... WARNING: can't generate a core file - core tests suppressed - check ulimit -c WARNING: can't generate a core file - core tests suppressed - check ulimit -c DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file WARNING: can't generate a core file - core tests suppressed - check ulimit -c DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file WARNING: can't generate a core file - core tests suppressed - check ulimit -c DUPLICATE: gdb.base/corefile-buildid.exp: could not generate core file The WARNING itself is related to my test environment, not the test istelf so I do not try to address it here. Fix the DUPLICATEs by ensuring the test name is generated consistently with the rest of the file (i.e. by using $prefix in the name). Tested on x86_64-linux. --- gdb/testsuite/gdb.base/corefile-buildid.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/corefile-buildid.exp b/gdb/testsuite/gdb.base/corefile-buildid.exp index 15509be7039..bb1d4051b07 100644 --- a/gdb/testsuite/gdb.base/corefile-buildid.exp +++ b/gdb/testsuite/gdb.base/corefile-buildid.exp @@ -260,7 +260,7 @@ proc do_corefile_buildid_tests {args} { # Find the core file. set corefile [core_find $program_to_run] if {$corefile == ""} { - untested "could not generate core file" + untested "$suffix: could not generate core file" return } verbose -log "corefile is $corefile" -- 2.33.1