From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6A1XDUOKmmEyUQAAWB0awg (envelope-from ) for ; Sun, 21 Nov 2021 13:04:51 -0500 Received: by simark.ca (Postfix, from userid 112) id 34BE31F0CE; Sun, 21 Nov 2021 13:04:51 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id BC3AE1EDF0 for ; Sun, 21 Nov 2021 13:04:50 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 60AC23858428 for ; Sun, 21 Nov 2021 18:04:50 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 60AC23858428 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637517890; bh=4IL9UA5lX7sw3uDIFmntGbZzVNMtjxlg+XLF9IPTCTY=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=CktBTmi5q53rz4P36DYh9DiGIwLe6/6gHu83KDri84AlV5ee4aVaG1nMdw/jLJWb6 juG8agyN5GsE08KeJbtwq87T3AQ49nI6XPXNrPORb7rHErD2+u6XUbZE2jReeJq2uc mOtJSeqg00SlIXQblo+8H+MAOdc+yO3m52onYwgQ= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id 9B055385841F for ; Sun, 21 Nov 2021 17:57:44 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 9B055385841F Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:e409:90b0:99cc:9f98]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 517908554E; Sun, 21 Nov 2021 17:57:43 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 16/29] gdb/testsuite: Remove duplicates from gdb.base/ui-redirect.exp Date: Sun, 21 Nov 2021 17:56:23 +0000 Message-Id: <20211121175636.779325-17-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Sun, 21 Nov 2021 17:57:43 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite, I have: Running .../gdb/testsuite/gdb.base/ui-redirect.exp ... DUPLICATE: gdb.base/ui-redirect.exp: redirect while already logging: set logging redirect off Fix by moving the first 'set logging redirect off' at the end of the previous [with_test_prefix] test block. The statement's purpose is to clean the on flag set in this previous block, so moving it there makes sense and does not change the sequence of commands in the test file.. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/ui-redirect.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp index 363c563a5a1..6ed9c49c427 100644 --- a/gdb/testsuite/gdb.base/ui-redirect.exp +++ b/gdb/testsuite/gdb.base/ui-redirect.exp @@ -95,10 +95,10 @@ with_test_prefix "redirect" { gdb_test_no_output "userdefined" gdb_test "set logging off" "Done logging to /dev/null\\." gdb_test "help" "List of classes of commands:.*" + gdb_test_no_output "set logging redirect off" } with_test_prefix "redirect while already logging" { - gdb_test_no_output "set logging redirect off" gdb_test "set logging on" \ "Copying output to /dev/null.*Copying debug output to /dev/null\\." gdb_test "set logging redirect on" \ -- 2.33.1