From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id KEosAqOJmmEyUQAAWB0awg (envelope-from ) for ; Sun, 21 Nov 2021 13:02:11 -0500 Received: by simark.ca (Postfix, from userid 112) id 0742D1F0CE; Sun, 21 Nov 2021 13:02:11 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9810C1EDF0 for ; Sun, 21 Nov 2021 13:02:10 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 334613858411 for ; Sun, 21 Nov 2021 18:02:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 334613858411 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637517730; bh=VW3EEfOkTYnL5CqF+GzmTGVKlfRvxIm/ok2BfZPNJS4=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=mw2CzAhBH3m5h3HAJTF9AoG6cns6a50AkpN6QNejstBzA4Hh/A4ipzgBxlxp0YOWj T9feytF9qFB+ggwgXq3sB6iXensLSMHWf7+aHgv5WTkKyU/6tlgP5Fn8AWuCQEtOpG 5MmGlUZzXeBEuZ+wD1mpgI1xnK1mHMAyXtRhyjYY= Received: from lndn.lancelotsix.com (lndn.lancelotsix.com [51.195.220.111]) by sourceware.org (Postfix) with ESMTPS id E1924385843F for ; Sun, 21 Nov 2021 17:57:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E1924385843F Received: from Plymouth.lan (unknown [IPv6:2a02:390:9086:0:e409:90b0:99cc:9f98]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id C5A9A854F8; Sun, 21 Nov 2021 17:57:35 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH 10/29] gdb/testsuite: Remove duplicates from gdb.base/del.exp Date: Sun, 21 Nov 2021 17:56:17 +0000 Message-Id: <20211121175636.779325-11-lsix@lancelotsix.com> X-Mailer: git-send-email 2.33.1 In-Reply-To: <20211121175636.779325-1-lsix@lancelotsix.com> References: <20211121175636.779325-1-lsix@lancelotsix.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Sun, 21 Nov 2021 17:57:37 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" When running the testsuite, I have: Running .../gdb/testsuite/gdb.base/del.exp ... DUPLICATE: gdb.base/del.exp: info break after removing break on main Refactor slightly this test to run the various configurations under foreach_with_prefix so each variant is automatically prefixed, ensuring that the forgotten custom test name cannot happen. Tested on x86_64-linux. --- gdb/testsuite/gdb.base/del.exp | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.base/del.exp b/gdb/testsuite/gdb.base/del.exp index 7b1f24b8686..8dc12b7089b 100644 --- a/gdb/testsuite/gdb.base/del.exp +++ b/gdb/testsuite/gdb.base/del.exp @@ -32,30 +32,30 @@ proc test_delete_alias { alias } { # First of all, remove all previous breakpoints if there were any, # and then verify that we do not have any breakpoint lying around. gdb_test_no_output "delete" \ - "remove all breakpoints ($alias)" + "remove all breakpoints" gdb_test "info break" \ "No breakpoints or watchpoints." \ - "info break after removing break on main" + "info break after clearing breakpoints" + - # Now, insert a breakpoint at an easy location, and then remove it # using $alias. We verified that the removal worked by checking # the list of breakpoints. gdb_test "break -q main" \ "Breakpoint.*at.* file .*$srcfile, line.*" \ - "breakpoint insertion ($alias)" - + "breakpoint insertion" + gdb_test_no_output "$alias \$bpnum" \ - "Remove last breakpoint ($alias)" - + "Remove last breakpoint" + gdb_test "info break" \ "No breakpoints or watchpoints." \ - "info break after removing break on main ($alias)" + "info break after removing break on main" } # Test various shortcut forms of the "delete" command. -test_delete_alias "del" -test_delete_alias "d" - +foreach_with_prefix alias {"del" "d"} { + test_delete_alias $alias +} -- 2.33.1