From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ltgsB9W9lGFUYwAAWB0awg (envelope-from ) for ; Wed, 17 Nov 2021 03:31:17 -0500 Received: by simark.ca (Postfix, from userid 112) id 0DBA01F0C1; Wed, 17 Nov 2021 03:31:17 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 977701EDEE for ; Wed, 17 Nov 2021 03:31:16 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id EDC3E385BF83 for ; Wed, 17 Nov 2021 08:31:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org EDC3E385BF83 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1637137876; bh=hn0Rcp/irrHxD7gINl/aGWoNKG6EXOd5y+zR6tIFkoM=; h=Date:To:Subject:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=VGGOddTmfmErmrEZ28fPbECR90tJa6RiQHviMD7lr7DbpjX3Q3nCafs6WSa/jPz9x /FOM5VKWBJ+6gXCu8KOYjOoc2jxmQlMz/lyDb/m/dzIrympfdFtNjEKdmTMr8Gd6gy W1B3cVvrMG8Mii7NqroW9eO8RtgaLzt+xe4rYEsg= Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id D7E8A385BF83; Wed, 17 Nov 2021 08:29:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D7E8A385BF83 Received: by mail-wr1-x430.google.com with SMTP id n29so2978393wra.11; Wed, 17 Nov 2021 00:29:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hn0Rcp/irrHxD7gINl/aGWoNKG6EXOd5y+zR6tIFkoM=; b=P39SKs0CySxBrtbF5Ii40rnOUjoAclCePwWhU64OwbpcJlEbn46qfDrU6f+uL5f4fg /1K7n66CsxoIp/63ggOYUQPcPaBLYqSWI0Lr76crt3rRNWderi9niqw51pDz7d37HUY9 9CW2hlHlFcDG3bAGcL+L9fxOr+9VAth7cc7eV+phpyWnN3A6Y2QmRMiyJejS5SecnufD 61QSyhHpwFo7UX/nJrm+itHhw05R+myGc1/eHcDWRtBYrNU/dzPGDXzt0XPGcn67b2fc 5ijIDks8KwW2yaFAPYD4FMTU9sy26FyogZNvGFlj6GK/lSAbCLPjQ+SW/89dLW73wLtv fDjg== X-Gm-Message-State: AOAM531rhQuCWOblK4JoXR1KI+xoZeVqZwBmaJz8RaUNpqcvN12ikb4T t1u21eBuvJbTornEaJciqA8= X-Google-Smtp-Source: ABdhPJwoQSAjrvXS3v+sxQaoEXBMi5/vNVQVuD6VjsplZCT3zQfPhm7TLh1CjwAXYz02Kfu3C9haWA== X-Received: by 2002:a5d:59a2:: with SMTP id p2mr18380264wrr.252.1637137743810; Wed, 17 Nov 2021 00:29:03 -0800 (PST) Received: from nz (host81-147-8-68.range81-147.btcentralplus.com. [81.147.8.68]) by smtp.gmail.com with ESMTPSA id l11sm19429072wrp.61.2021.11.17.00.29.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 17 Nov 2021 00:29:03 -0800 (PST) Date: Wed, 17 Nov 2021 08:29:02 +0000 To: Simon Marchi Subject: Re: [PATCH v2] gdb/nat/linux-osdata.c: fix build on gcc-12 (string overfow) Message-ID: <20211117082852.28a50b9f@nz> In-Reply-To: References: <20211116235521.223574-1-slyich@gmail.com> X-Mailer: Claws Mail 4.0.0 (GTK+ 3.24.30; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Sergei Trofimovich via Gdb-patches Reply-To: Sergei Trofimovich Cc: Sergei Trofimovich , binutils@sourceware.org, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, 16 Nov 2021 20:09:57 -0500 Simon Marchi wrote: > On 2021-11-16 18:55, Sergei Trofimovich wrote: > > From: Sergei Trofimovich > > > > On gcc-12 build fails as: > > > > ../../gdbserver/../gdb/nat/linux-osdata.c: In function 'void linux_xfer_osdata_processes(buffer*)': > > ../../gdbserver/../gdb/nat/linux-osdata.c:330:39: error: > > '__builtin___sprintf_chk' may write a terminating nul past the end of the destination [-Werror=format-overflow=] > > 330 | sprintf (core_str, "%d", i); > > | ^ > > > > It's an off-by-one case in an infeasible scenario for negative > > huge core count. The change switches to std::string for memory > > handling. > > > > Tested by running 'info os processes' and checking CPU cores column. > > Thanks, this is ok. Do you have push access, or do you want me to push > it on your behalf? Pushed as: https://sourceware.org/git/?p=binutils-gdb.git;a=commitdiff;h=486f9e20e037f1eea2dce98dc393db60df5feef3 Thank you! -- Sergei