From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id XcniNA1UXGGGGQAAWB0awg (envelope-from ) for ; Tue, 05 Oct 2021 09:33:01 -0400 Received: by simark.ca (Postfix, from userid 112) id C588A1EE1B; Tue, 5 Oct 2021 09:33:01 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 9C64C1E813 for ; Tue, 5 Oct 2021 09:33:00 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5C1E8385AC31 for ; Tue, 5 Oct 2021 13:32:59 +0000 (GMT) Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by sourceware.org (Postfix) with ESMTPS id E5692385840B for ; Tue, 5 Oct 2021 13:32:48 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org E5692385840B Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x431.google.com with SMTP id r7so21866096wrc.10 for ; Tue, 05 Oct 2021 06:32:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=Bo5h1YRLuM7/Dd9bF+umXAp/25tTkCiH75Sn6OxeTGA=; b=IZ9p6+cCr2kJudqsqBm7cxcrhjCzhZCsvoYuu8YkJaEi1iIbEIbYCPrxcWWXNt3CgE a0cbzR/wTCX586AXd4zn723Xv1w3BpCtWu90W4J1SFaQ9UjPK3/+dkbU1WNBus4hP73S pf+RlAy75sq2+0Rg2cjgB8xfUdJkag8soE31yc6ci/TRnXE7hs8TipNYPJYOYI3NxHWo mldEBOudxfsKDX/O/6ztBn908cdSV0u1RMmPH45g/rGU+c5eTgdfcB4/XRMK6+m2HH9n wxiBeJfTE0Zr27lZOCcwTIO6Zs6XfQaBM3lgt7xz8rzEzS31NPE67p05wNbl4YEtQKMK HJYg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=Bo5h1YRLuM7/Dd9bF+umXAp/25tTkCiH75Sn6OxeTGA=; b=RkAQ+TnDVgOC4L67na9Vt/NXiw4PmviJB6KVJkKIeeq1YtlUtGiGlbxLvKgdNhxdWE i0nRc3envYzIM7XtPXGTdzYZKKiOci755nWJWsbgr+nqz+myOUo7zjeuw1QoKwyd030k KreXb8QRmie5gwZXJFlNpafPtnbhZytBS55EpyrJejiTdRkK0pk3FeyFAB3LWg8SQd6m WoZDxesSm1rKFjajUl2FQ8JxqGH+ZRaVd4MeFXjqZda7qvooCBj9huu++heaGLB9RDqd sAzuNmf8cS7N6DIgsB9XJhJ6TBC6yQbr1G3hQQh6NmDMddu+G8wl8CJTUvyACqnPg0NQ 8nNg== X-Gm-Message-State: AOAM531llLXsZmxfKxcXHsOBwiwu5VQbMS4SmXd0YJa3nVdgf/zlghFw btafCkQAEtCWaMoUx+q5uELew3l27EijKQ== X-Google-Smtp-Source: ABdhPJw/Ej20aVjEChdriyk+fCs2BvvYqqW/zgG7ya77rPF60rUep65h9aac+knQ4Tq9FJUUPtoVWA== X-Received: by 2002:adf:a2d4:: with SMTP id t20mr21967780wra.229.1633440767010; Tue, 05 Oct 2021 06:32:47 -0700 (PDT) Received: from localhost (host86-169-137-11.range86-169.btcentralplus.com. [86.169.137.11]) by smtp.gmail.com with ESMTPSA id x21sm2074187wmc.14.2021.10.05.06.32.46 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Oct 2021 06:32:46 -0700 (PDT) Date: Tue, 5 Oct 2021 14:32:45 +0100 From: Andrew Burgess To: Tom de Vries Subject: Re: [PATCH][gdb/testsuite] Fix FAIL in gdb.mi/mi-nsmoribund.exp Message-ID: <20211005133245.GP1900093@embecosm.com> References: <20211005105408.GA30962@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20211005105408.GA30962@delia> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:32:20 up 16 days, 4:41, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Tom de Vries [2021-10-05 12:54:10 +0200]: > Hi, > > Since commit e36788d1354 "[gdb/testsuite] Fix handling of nr_args < 3 in > mi_gdb_test" we run into: > ... > PASS: gdb.mi/mi-nsmoribund.exp: print done = 1 > Expecting: ^(.*[^M > ]+)?([^ > ]*^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"^M > \*running,thread-id="[0-9]+"[^M > ]+[(]gdb[)] ^M > [ ]*) > 103-exec-continue --all^M > =library-loaded,id="/lib64/libgcc_s.so.1",target-name="/lib64/libgcc_s.so.1",\ > host-name="/lib64/libgcc_s.so.1",symbols-loaded="0",thread-group="i1",\ > ranges=[{from="0x00007ffff22a5010",to="0x00007ffff22b6365"}]^M > 103^running^M > *running,thread-id="5"^M > (gdb) ^M > FAIL: gdb.mi/mi-nsmoribund.exp: 103-exec-continue --all (unexpected output) > ... > > The regexp expect running messages for all threads, but we only get one for > thread 5. > > The test-case uses non-stop mode, and when the exec-continue --all command is > issued, thread 5 is stopped and all other threads are running. Consequently, > only thread 5 is resumed, and reported as running. > > Fix this by updating the regexp. That seems to make sense. LGTM. Thanks, Andrew > > Tested on x86_64-linux. > > Any comments? > > Thanks, > - Tom > > [gdb/testsuite] Fix FAIL in gdb.mi/mi-nsmoribund.exp > > --- > gdb/testsuite/gdb.mi/mi-nsmoribund.exp | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp > index 58de9591da8..73a8d1ac71b 100644 > --- a/gdb/testsuite/gdb.mi/mi-nsmoribund.exp > +++ b/gdb/testsuite/gdb.mi/mi-nsmoribund.exp > @@ -121,7 +121,11 @@ set re [list \ > [string_list_to_regexp " = 1" \\ n {"} \r\n ^ done]] > set re [join $re ""] > mi_gdb_test "print done = 1" $re > -mi_gdb_test "103-exec-continue --all" "\[^\n\]*\r\n$running_re" > + > +# Command exec-continue --all attempts to resume all threads, but only > +# thread 5 was stopped, so only that one is reported as running. > +set running_re "\\*running,thread-id=\"5\"" > +mi_gdb_test "103-exec-continue --all" "\[^\n\]*\r\n$running_re" \ > > gdb_expect { > -re "\\*stopped,reason=\"exited-normally\"" {