From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mEF8O0pFVmEOaQAAWB0awg (envelope-from ) for ; Thu, 30 Sep 2021 19:16:26 -0400 Received: by simark.ca (Postfix, from userid 112) id EF67E1EDDB; Thu, 30 Sep 2021 19:16:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A18FE1E4A3 for ; Thu, 30 Sep 2021 19:16:26 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB1913857C56 for ; Thu, 30 Sep 2021 23:16:25 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB1913857C56 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1633043785; bh=bXeIjIt6t82d3qKvUtwnOVpt11FHVR8Up6rFf3aA0Mc=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=naukp+JT/FVbVmpGBRHJJ3GMdkEVkOxkzDlqXeOp1iVwYWN4FmJPoEeLp8VZ+udiA DGEOfNHwJ2y7FU5fxYX1+LS6KE+QKZdJIXVp/m98IUfkBjakiVhLAdoYqgnMTqWftX qeKhICHUc51nnlDNdjCay8yEUzxBOi2cNbH5XsRI= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id D0E4A3858C2C for ; Thu, 30 Sep 2021 23:16:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org D0E4A3858C2C Received: from ubuntu.lan (unknown [IPv6:2a02:390:9086::635]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id AAC9B80D76; Thu, 30 Sep 2021 23:16:03 +0000 (UTC) Date: Thu, 30 Sep 2021 23:15:58 +0000 To: Simon Marchi Subject: Re: [PATCH v4 1/4] gdb: Introduce setting construct within cmd_list_element Message-ID: <20210930231558.3ka4vglabsdq4ern@ubuntu.lan> References: <20210929215011.1489639-1-lsix@lancelotsix.com> <20210929215011.1489639-2-lsix@lancelotsix.com> <90e82ecb-d1ab-d866-ccdb-b6ab64e52f5e@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Thu, 30 Sep 2021 23:16:03 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" > > I think the change below should fix it. Hi, Sorry for this. I did rebase just few days ago and let this one slip through. I’ll fix this and address your other comments shortly. > > Since it's one of those > settings that reverts the value if the new value is invalid, it could > eventually be changed to use a getter/setter, so that the setter simply > rejects the new value if it's not valid. I’ll do that in separate commit once this series is pushed if this ok with you. For the moment I’ll just fix the current compile error with something similar to what you propose bellow. Thanks a lot for the review. Best, Lancelot. > > > From 96df63a390451e0bbdfc74784ea09a3aa360656d Mon Sep 17 00:00:00 2001 > From: Simon Marchi > Date: Thu, 30 Sep 2021 08:26:41 -0400 > Subject: [PATCH] fix > > Change-Id: Id78157cacf2de9cfacba1f19dea17b0f7b65aa0f > --- > gdb/bt-utils.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/gdb/bt-utils.c b/gdb/bt-utils.c > index 79e6e090d428..2054e68c6e5a 100644 > --- a/gdb/bt-utils.c > +++ b/gdb/bt-utils.c > @@ -29,15 +29,15 @@ gdb_internal_backtrace_set_cmd (const char *args, int from_tty, > cmd_list_element *c) > { > gdb_assert (c->type == set_cmd); > - gdb_assert (c->var_type == var_boolean); > - gdb_assert (c->var != nullptr); > + gdb_assert (c->var->type () == var_boolean); > + gdb_assert (c->var.has_value ()); > > #ifndef GDB_PRINT_INTERNAL_BACKTRACE > - bool *var_ptr = (bool *) c->var; > + bool val = c->var->get (); > > - if (*var_ptr) > + if (val) > { > - *var_ptr = false; > + c->var->set (false); > error (_("support for this feature is not compiled into GDB")); > } > #endif > -- > 2.33.0 >