From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id COEHKBirTWESNAAAWB0awg (envelope-from ) for ; Fri, 24 Sep 2021 06:40:24 -0400 Received: by simark.ca (Postfix, from userid 112) id A13AB1EE25; Fri, 24 Sep 2021 06:40:24 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 00AA51EDDB for ; Fri, 24 Sep 2021 06:40:24 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B7D93858437 for ; Fri, 24 Sep 2021 10:40:23 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B7D93858437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632480023; bh=qzopNjQt1GIRGpFBEdq/MGTPc5aeDd+MmyBwx6CmYV4=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=LqDakLYBQBXEi6NPADYZ/nWrMYDS2+3jtBf5t6mktGqSmUNI4bd8OWmp8ACO6IZYp itzu7Nfu7cYhi9RRFPnR//vULZRpcif5Twxz4r6aBXB1b+Hy/JRF+2MerEitEoBJVO BhZS0lu4wTsnZugPOrcm2Q9xS20NN9xnzXXIvPaU= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id BC23B3858402 for ; Fri, 24 Sep 2021 10:40:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BC23B3858402 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id DEC5B1FFE6 for ; Fri, 24 Sep 2021 10:40:03 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id CDB5913E14 for ; Fri, 24 Sep 2021 10:40:03 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id aPo1MQOrTWGoVwAAMHmgww (envelope-from ) for ; Fri, 24 Sep 2021 10:40:03 +0000 Date: Fri, 24 Sep 2021 12:40:02 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Use pie/nopie instead of ldflags=-pie/-no-pie Message-ID: <20210924104000.GA1442@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, I noticed two test-case that use ldflags=-pie and ldflags-no-pie, instead of the canonical pie and nopie options, which would typically also add additional_flags=-fPIE respectively additional_flags=-fno-pie. There is no indication that this is on purpose, so replace these with pie and nopie. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Use pie/nopie instead of ldflags=-pie/-no-pie --- gdb/testsuite/gdb.base/load-command.exp | 2 +- gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/gdb/testsuite/gdb.base/load-command.exp b/gdb/testsuite/gdb.base/load-command.exp index 6de885a7243..8847aff3b74 100644 --- a/gdb/testsuite/gdb.base/load-command.exp +++ b/gdb/testsuite/gdb.base/load-command.exp @@ -20,7 +20,7 @@ standard_testfile # Disable generation of position independent executable (PIE). Otherwise, we # would have to manually specify an offset to load. -set opts {debug ldflags=-no-pie} +set opts {debug nopie} if [prepare_for_testing "failed to prepare" $testfile $srcfile $opts] { return -1 diff --git a/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp b/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp index 773e20031bc..21053564d8e 100644 --- a/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp +++ b/gdb/testsuite/gdb.dwarf2/fission-loclists-pie.exp @@ -40,7 +40,7 @@ standard_testfile .S set obj [standard_output_file "${testfile}.o"] set dwo [standard_output_file "${testfile}.dwo"] if [build_executable_and_dwo_files "$testfile.exp" "${binfile}" \ - {nodebug ldflags=-pie} \ + {nodebug pie} \ [list $srcfile [list nodebug split-dwo additional_flags=-DDWO=\"$dwo\"] \ $obj]] { return -1