From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id mmJoM8eKSGHPDAAAWB0awg (envelope-from ) for ; Mon, 20 Sep 2021 09:21:11 -0400 Received: by simark.ca (Postfix, from userid 112) id 6DCDC1EE25; Mon, 20 Sep 2021 09:21:11 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0E7061EE14 for ; Mon, 20 Sep 2021 09:21:09 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8782F3858020 for ; Mon, 20 Sep 2021 13:21:08 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8782F3858020 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1632144068; bh=DxrQAfpscE5BGf7mmZAY1O9Ws1TuK5J6oABW5ucegVw=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=cm0n6Iq1KE1I7BtzcSUqgZEDe05c0ZFtNGY1QHMgL0N80cWjGoN0dTM+vqeISezu7 ypxTMVb88rSWnM3gpQ0Le7ondXRGIHnqU3j8QYvH9SGyWPwCjgp5ewkSV93bJAA5uq fQW5hqV2FlxnNX6O0OIKfGHyZDw6uY8GnED+8edI= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id DCD8C385701C for ; Mon, 20 Sep 2021 13:08:26 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DCD8C385701C Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 18F6E1FD4D for ; Mon, 20 Sep 2021 13:08:26 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F313D12FF7 for ; Mon, 20 Sep 2021 13:08:25 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id SPfFOcmHSGG0RwAAMHmgww (envelope-from ) for ; Mon, 20 Sep 2021 13:08:25 +0000 Date: Mon, 20 Sep 2021 15:08:24 +0200 To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.ada/big_packed_array.exp xfail for -m32 Message-ID: <20210920130822.GA23259@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, With test-case gdb.ada/big_packed_array.exp and target board unix/-m32 I run into: ... (gdb) print bad^M $2 = (0 => 0 , 160)^M (gdb) FAIL: gdb.ada/big_packed_array.exp: scenario=minimal: print bad ... The problem is that while the variable is an array of 196 bits (== 24.5 bytes), the debug information describes it as 25 unsigned char. This is PR gcc/101643, and the test-case contains an xfail for this, which catches only: ... (gdb) print bad^M $2 = (0 => 0 )^M ... Fix this by updating the xfail pattern. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.ada/big_packed_array.exp xfail for -m32 --- gdb/testsuite/gdb.ada/big_packed_array.exp | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/gdb/testsuite/gdb.ada/big_packed_array.exp b/gdb/testsuite/gdb.ada/big_packed_array.exp index 32ff0dd3e1c..e62f053166b 100644 --- a/gdb/testsuite/gdb.ada/big_packed_array.exp +++ b/gdb/testsuite/gdb.ada/big_packed_array.exp @@ -43,6 +43,7 @@ foreach_with_prefix scenario {all minimal} { set re "= \\(false \\)" set re_xfail "= \\(0 => 0 \\)" + set re_xfail2 "= \\(0 => 0 , ($decimal)\\)" gdb_test_multiple "print bad" "" { -re -wrap $re { pass $gdb_test_name @@ -54,5 +55,14 @@ foreach_with_prefix scenario {all minimal} { } fail $gdb_test_name } + -re -wrap $re_xfail2 { + set last $expect_out(1,string) + if { $have_xfail && [string is integer $last] \ + && [expr ($last & 0xf) == 0] } { + # gcc/101643 + setup_xfail *-*-* + } + fail $gdb_test_name + } } }