From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 7WgCA6JcSGHDBwAAWB0awg (envelope-from ) for ; Mon, 20 Sep 2021 06:04:18 -0400 Received: by simark.ca (Postfix, from userid 112) id ED0F91EE25; Mon, 20 Sep 2021 06:04:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.8 required=5.0 tests=DKIM_INVALID,DKIM_SIGNED, MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0A5531EDDB for ; Mon, 20 Sep 2021 06:04:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 479063858421 for ; Mon, 20 Sep 2021 10:04:16 +0000 (GMT) Received: from mail-wr1-x433.google.com (mail-wr1-x433.google.com [IPv6:2a00:1450:4864:20::433]) by sourceware.org (Postfix) with ESMTPS id B20D73858C60 for ; Mon, 20 Sep 2021 10:04:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org B20D73858C60 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x433.google.com with SMTP id w17so19772998wrv.10 for ; Mon, 20 Sep 2021 03:04:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=pNYHp8STXtnmA7NP+R17SlHujJKyRKu1584L4zqZSHo=; b=eQUNy+D+fflcwCNQn//ACIbj1wllHwi4zdBUXRO+Q00BLchj1pJTdPIUdSvTSx0sMa 5P2kgAVXwErmlv/7dt6L7ulz9ykx+8YQ/NY37v2blQZ3uvE3qQn/BPuzqN8lWLxJkHCj Q+srCObxwDWcQ5594kZeD4X8UmDjLsvcSPlCT3jh7D2n/VTnnMeQ4ofnZveH4zRn2lp9 qKYtLqO6Dz/5a021OLX4rgWmn9zsPUohfxuDBlp7kOVGqexFjgEAig0TYa+r0swVzXl5 zXEY7MradF8acEHSDH0+eMDFUOVeXOEKktzmsuA7gGIt/dqrQrTuGnyHtWegkBEOCFRX 13Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=pNYHp8STXtnmA7NP+R17SlHujJKyRKu1584L4zqZSHo=; b=C6Tvvzizr/mcyyaXt/rTqZeoYnwsCldMBDqAJ6sMeCIx/6zo9Pxamjo8CX41jX4TCY 4MPE0XqHkj3kHD2guB8o90KNURgaUPOFIoQtGtU3ASBOzqIu9Qa1Q0tLIvYwnDZNm60I 9WyWJnTXE4jwIKv9u2FdyHWsN+AgF3oVi9pEloaLOf18O114xOYKaLYFlwdBrmtdUoiu 6dgbVshv2FNtS+35lo3Bs1SEP8z9AeqzatREGiM00K7isPEiAWOjaAwMMlLXekEWIEkC HMZtBdCPMs+jNdybn7UTJ4j69A6kv0hIcf11CTe9KvhkFKqg0R8wXcJwnTh5QXXBU2VL QZHw== X-Gm-Message-State: AOAM532FBw0Qg4ysvvOpKE4J3hJ0jYTON3fvRJJbPBiClnonOnz0M0lf IJStb2lDSUzEzrfpqTXUsxh1/Wfmo1eZ9A== X-Google-Smtp-Source: ABdhPJx1TMUiNOJpKaEhQewea2vbgmeDhKepXjaEawlwOI3/0NWT0e1RVZnwBiVNcPMx0v8k+R7L7A== X-Received: by 2002:adf:d1c4:: with SMTP id b4mr24725376wrd.233.1632132243839; Mon, 20 Sep 2021 03:04:03 -0700 (PDT) Received: from localhost (host86-153-58-62.range86-153.btcentralplus.com. [86.153.58.62]) by smtp.gmail.com with ESMTPSA id u13sm15670710wrt.41.2021.09.20.03.04.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 20 Sep 2021 03:04:03 -0700 (PDT) Date: Mon, 20 Sep 2021 11:04:02 +0100 From: Andrew Burgess To: Simon Marchi Subject: Re: [PATCHv5] gdb: prevent an assertion when computing the frame_id for an inline frame Message-ID: <20210920100402.GD4950@embecosm.com> References: <20210727101003.2910993-1-andrew.burgess@embecosm.com> <20210809154122.3468792-1-andrew.burgess@embecosm.com> <20210823094159.GC2581@embecosm.com> <87ce1eab-aba1-7282-97cd-89233e3d7f54@palves.net> <20210823123109.GD2581@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210823123109.GD2581@embecosm.com> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 11:00:10 up 1 day, 1:09, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Simon, I wonder if you had any thoughts on v5? As this patch is closer to v2 which Pedro was happy with, I'd really like to hear your opinions on this version. Thanks, Andrew * Andrew Burgess [2021-08-23 13:31:09 +0100]: > * Pedro Alves [2021-08-23 11:26:49 +0100]: > > > Hi Andrew, > > > > Sorry I hadn't responded yet. I was out on vacation a few weeks ago, and thought I would be able to > > get to this once I got back, but I got immediately pulled to a tight internal deadline instead. FWIW, I've > > been very frustrated about failing to reply to you. I should be able to take a look this week, though. > > > > On 2021-08-23 10:41 a.m., Andrew Burgess wrote: > > > Ping! > > > > > > Simon, what are your thoughts on this approach? From what I recall of > > > our discussion on IRC your concerns with my original patch were that > > > after my change the function implementation no longer matched with the > > > function name, this made GDB's internal APIs confusing and > > > inconsistent. > > > > > > With this patch I've tried to avoid this by renaming the functions to > > > hopefully make the API clearer. > > > > > > I'm just guessing, but I suspect it was the use of exceptions that > > > Pedro wasn't happy with, so maybe if you're happy with this latest > > > patch we could merge this change, given Pedro already approved the > > > pre-exception patch. > > > > I don't recall the discussion with Simon, but yes, use custom exceptions > > for this doesn't sound great to me. Let me take a better look. > > Thanks for taking the time to reply. I completely understand other > pressures getting in the way of being as active on the m/l. Even just > knowing for sure which part of the patch you didn't like is great > information as I can start coming up with alternatives. So I'm always > grateful for any feedback, no matter how terse. > > Thanks again, > Andrew