From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +NxwGYX7PmG+GwAAWB0awg (envelope-from ) for ; Mon, 13 Sep 2021 03:19:33 -0400 Received: by simark.ca (Postfix, from userid 112) id 639E71EE25; Mon, 13 Sep 2021 03:19:33 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id A93A11EE18 for ; Mon, 13 Sep 2021 03:19:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 04A323858034 for ; Mon, 13 Sep 2021 07:19:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 04A323858034 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631517572; bh=DSBVeRydwr9YRkKrTRC8xVmfVjr0Bghm7DC1OqQukRM=; h=Date:To:Subject:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=ulzALjtzWLcIDzDex+WdXSkTpuB2To9l/iLfddwfrEIey421jsZzBIrH+LoBDeKwD xjdOrWlxHPl1V4nBU5laeUcgATdAi/1QHRi4CYBph0Ws1cTCHp1z6W/qZvVgi5AMtH fbqINP4tnCiJDTQEC1K6Qy9Yq+XKgM2QHDBHompw= Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 98A16385842B for ; Mon, 13 Sep 2021 07:19:13 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 98A16385842B Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CD7141FF9E for ; Mon, 13 Sep 2021 07:19:12 +0000 (UTC) Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id BBD19132AB for ; Mon, 13 Sep 2021 07:19:12 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id e2jaLHD7PmHYfAAAGKfGzw (envelope-from ) for ; Mon, 13 Sep 2021 07:19:12 +0000 Date: Mon, 13 Sep 2021 09:19:11 +0200 To: gdb-patches@sourceware.org Subject: [PATCH][gdb/testsuite] Check for valid test name Message-ID: <20210913071908.GA3469@delia.home> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, When running gdb.base/batch-exit-status.exp I noticed that the test name contains a newline: ... PASS: gdb.base/batch-exit-status.exp: : No such file or directory\.^M : No such file or directory\.: [lindex $result 2] == 0 ... Check for this in ::CheckTestNames::check, such that we have a warning: ... PASS: gdb.base/batch-exit-status.exp: : No such file or directory\.^M : No such file or directory\.: [lindex $result 2] == 0 WARNING: Newline in test name ... Tested on x86_64-linux. Any comments? Thanks, - Tom [gdb/testsuite] Check for valid test name --- gdb/testsuite/lib/check-test-names.exp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/testsuite/lib/check-test-names.exp b/gdb/testsuite/lib/check-test-names.exp index 1de7624d5c5..db76abab990 100644 --- a/gdb/testsuite/lib/check-test-names.exp +++ b/gdb/testsuite/lib/check-test-names.exp @@ -93,6 +93,13 @@ namespace eval ::CheckTestNames { return $message } + # Check if MESSAGE is a well-formed test name. + proc _check_name { message } { + if { [regexp \n $message]} { + warning "Newline in test name" + } + } + # Check if MESSAGE contains either the source path or the build path. # This will result in test names that can't easily be compared between # different runs of GDB. @@ -110,6 +117,8 @@ namespace eval ::CheckTestNames { if [ _check_duplicates $message ] { clone_output "DUPLICATE: $message" } + + _check_name $message } # If COUNT is greater than zero, disply PREFIX followed by COUNT.