From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QN3HH5HGO2G/OwAAWB0awg (envelope-from ) for ; Fri, 10 Sep 2021 16:56:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 7F04C1EE24; Fri, 10 Sep 2021 16:56:49 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id D08CB1EE20 for ; Fri, 10 Sep 2021 16:56:48 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 4B7A4385841B for ; Fri, 10 Sep 2021 20:56:48 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 4B7A4385841B DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1631307408; bh=BlBLXE2KpF3WnqQUqjXXx74A1cQSCJ6/4HpRp1nThLI=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=YUdYMhlxRpzzTdZ6yVEW/O9Csjv5ElA7T+Hy568szj3Rhd1RTFFj0xDtF/nR4Y/6D we/rXRQkqu8JBksRKwOuZkHivKJA/xiu0TKd2aXcZ9/p7nn6HquIRG2jqJebDrxKch KgQDdmK7Kg1Cad8nl8KSbSJG3R+RoFvwytmAYiJY= Received: from barracuda.ebox.ca (barracuda.ebox.ca [96.127.255.19]) by sourceware.org (Postfix) with ESMTPS id 28701385AC1D for ; Fri, 10 Sep 2021 20:54:15 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 28701385AC1D X-ASG-Debug-ID: 1631307244-0c856e0388270230001-fS2M51 Received: from smtp.ebox.ca (smtp.ebox.ca [96.127.255.82]) by barracuda.ebox.ca with ESMTP id HzgY9GULpnHt4z9A (version=TLSv1 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Fri, 10 Sep 2021 16:54:04 -0400 (EDT) X-Barracuda-Envelope-From: simon.marchi@efficios.com X-Barracuda-RBL-Trusted-Forwarder: 96.127.255.82 Received: from epycamd.internal.efficios.com (173-246-27-5.qc.cable.ebox.net [173.246.27.5]) by smtp.ebox.ca (Postfix) with ESMTP id 9D843441D64; Fri, 10 Sep 2021 16:54:04 -0400 (EDT) X-Barracuda-RBL-IP: 173.246.27.5 X-Barracuda-Effective-Source-IP: 173-246-27-5.qc.cable.ebox.net[173.246.27.5] X-Barracuda-Apparent-Source-IP: 173.246.27.5 To: gdb-patches@sourceware.org Subject: [PATCH 2/6] gdb.base/foll-fork.exp: remove gating based on target triplet Date: Fri, 10 Sep 2021 16:53:58 -0400 X-ASG-Orig-Subj: [PATCH 2/6] gdb.base/foll-fork.exp: remove gating based on target triplet Message-Id: <20210910205402.3853607-2-simon.marchi@efficios.com> X-Mailer: git-send-email 2.33.0 In-Reply-To: <20210910205402.3853607-1-simon.marchi@efficios.com> References: <20210910205402.3853607-1-simon.marchi@efficios.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Barracuda-Connect: smtp.ebox.ca[96.127.255.82] X-Barracuda-Start-Time: 1631307244 X-Barracuda-Encrypted: DHE-RSA-AES256-SHA X-Barracuda-URL: https://96.127.255.19:443/cgi-mod/mark.cgi X-Virus-Scanned: by bsmtpd at ebox.ca X-Barracuda-Scan-Msg-Size: 1316 X-Barracuda-BRTS-Status: 1 X-Barracuda-Spam-Score: 0.00 X-Barracuda-Spam-Status: No, SCORE=0.00 using global scores of TAG_LEVEL=1000.0 QUARANTINE_LEVEL=1000.0 KILL_LEVEL=8.0 tests= X-Barracuda-Spam-Report: Code version 3.2, rules version 3.2.3.92507 Rule breakdown below pts rule name description ---- ---------------------- -------------------------------------------------- X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" It looks like this test has some code to check at runtime the support of fork handling of the target (see check_fork_catchpoints). So, it seems to me that the check based on target triplet at the beginning of the test is not needed. This kind of gating is generally not desirable, because we wouldn't think of updating it when adding fork support to a target. For example, FreeBSD supports fork, but it wasn't listed here. Change-Id: I6b55f2298edae6b37c3681fb8633d8ea1b5aabee --- gdb/testsuite/gdb.base/foll-fork.exp | 7 ------- 1 file changed, 7 deletions(-) diff --git a/gdb/testsuite/gdb.base/foll-fork.exp b/gdb/testsuite/gdb.base/foll-fork.exp index f777f2bda35..e6e84bd3bc0 100644 --- a/gdb/testsuite/gdb.base/foll-fork.exp +++ b/gdb/testsuite/gdb.base/foll-fork.exp @@ -13,13 +13,6 @@ # You should have received a copy of the GNU General Public License # along with this program. If not, see . -# Until "set follow-fork-mode" and "catch fork" are implemented on -# other targets... -# -if { ![istarget "*-*-linux*"] && ![istarget "*-*-openbsd*"] } then { - continue -} - # Test relies on checking follow-fork output. Do not run if gdb debug is # enabled as it will be redirected to the log. if [gdb_debug_enabled] { -- 2.33.0