From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Tif/Oni7LGE0aQAAWB0awg (envelope-from ) for ; Mon, 30 Aug 2021 07:05:28 -0400 Received: by simark.ca (Postfix, from userid 112) id D566A1EE1C; Mon, 30 Aug 2021 07:05:28 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 08B861E813 for ; Mon, 30 Aug 2021 07:05:28 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 96C27385743C for ; Mon, 30 Aug 2021 11:05:27 +0000 (GMT) Received: from mail-wr1-x42d.google.com (mail-wr1-x42d.google.com [IPv6:2a00:1450:4864:20::42d]) by sourceware.org (Postfix) with ESMTPS id 5DA2A3858D35 for ; Mon, 30 Aug 2021 11:05:08 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5DA2A3858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x42d.google.com with SMTP id d26so21923321wrc.0 for ; Mon, 30 Aug 2021 04:05:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=IjaVb/I5GzbKAosf4UCkvfkCJd+dLsRPtLlEoGqoR18=; b=ZQ4IrNIRj7ykxgz423VHRFoO8ZCtPEO1DzydxH6+CP15Hs5yJr4GyHw2SpQt0L1PoG i1QRGYi8zPl9mmmcQWbwJbFIfeEDnja0N/JBHN+RywEMS5GLFahrsu1IZ05Eng5G1O40 6hN38v4nVeFDO9h/MLH/ElFlOzjYmwxzXJmUene7/ypL5KKcOecClHaF3yiF2Kuo+0g4 UHB9ZULd1hCYSpRVgSm3I1EWieV9VNCxAzv/qZ/SNraobuTc9uZD8xldtAHCJANIvdIr 9KgtNyoGMLJ81Srta5pt0ZuZdauKoCvOe7MXWHuVt/tKyQ0II/+Nz8GZBwAzs3psrdz8 PbSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=IjaVb/I5GzbKAosf4UCkvfkCJd+dLsRPtLlEoGqoR18=; b=mWgWIA48jyWVe8d1mD6l6eEH/UrWA+Tcmx0mV+ynRPQXd1mf5HUagX+UIu1ys44uvY aFYijHTVaIEnPcXBvPLuUizDNdHXifxJAQeMuxgDB+R9p8KmEFWS8bcux1j0ikZdnfWY 9IB1UAorpBdy3lRKOqFvBoSaABzQO6WpJ7oMk56zb1Ab/zIjo540XPnIelgYDbefW5+M kCKipvR0USz6rNmzKmJmQh1SqSBV0YJLStc/elmjjEhv364SF8kcMp09gWIX/2G8DOcz xnYb4k35eFh2fWsdnAd3wpJMVc6PK4IcCh/skz1zJmp0SJD8tV3RShxjKeGWDUrzD1+8 TXkA== X-Gm-Message-State: AOAM531D68bXTYyDM+ae1DdF1XwpuSL9nM3S1Ohxu7sMbVjukIocXpl6 Hf/brcMJLj0qJPvtSFsrHIEA3ZsIcUryDA== X-Google-Smtp-Source: ABdhPJyxfAkI7CtEDomlcHSahdRKM7OfKR7zNxfA84Gw67YlkY/1hUoNlK+8hWIk5Qg9nwrZ7Nyutg== X-Received: by 2002:a5d:5262:: with SMTP id l2mr24741641wrc.190.1630321507417; Mon, 30 Aug 2021 04:05:07 -0700 (PDT) Received: from localhost (host86-188-49-44.range86-188.btcentralplus.com. [86.188.49.44]) by smtp.gmail.com with ESMTPSA id l19sm6232288wmj.34.2021.08.30.04.05.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 30 Aug 2021 04:05:07 -0700 (PDT) Date: Mon, 30 Aug 2021 12:05:06 +0100 From: Andrew Burgess To: Tom de Vries Subject: Re: [PATCH, master + 11][gdb/cli] Don't assert on empty string for core-file Message-ID: <20210830110506.GK2581@embecosm.com> References: <20210830103223.GA1126@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210830103223.GA1126@delia> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 12:02:41 up 12 days, 23:58, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Tom de Vries via Gdb-patches [2021-08-30 12:32:25 +0200]: > Hi, > > With current gdb we run into: > ... > $ gdb -batch '' '' > : No such file or directory. > pathstuff.cc:132: internal-error: \ > gdb::unique_xmalloc_ptr gdb_abspath(const char*): \ > Assertion `path != NULL && path[0] != '\0'' failed. > ... > > Fix this by skipping the call to gdb_abspath in core_target_open in the > empty-string case, such that we have instead: > ... > $ gdb -batch '' '' > : No such file or directory. > : No such file or directory. > $ > ... > > Tested on x86_64-linux. > > Any comments? The error messages aren't massively helpful, but I'm not convinced its worth putting too much effort into making them more hopeful, so LGTM. Thanks, Andrew > > Thanks, > - Tom > > [gdb/cli] Don't assert on empty string for core-file > > gdb/ChangeLog: > > 2021-08-30 Tom de Vries > > PR cli/28290 > * gdb/corelow.c (core_target_open): Skip call to gdb_abspath in the > empty-string case. > > gdb/testsuite/ChangeLog: > > 2021-08-30 Tom de Vries > > PR cli/28290 > * gdb.base/batch-exit-status.exp: Add gdb '' and gdb '' '' tests. > > --- > gdb/corelow.c | 3 ++- > gdb/testsuite/gdb.base/batch-exit-status.exp | 4 ++++ > 2 files changed, 6 insertions(+), 1 deletion(-) > > diff --git a/gdb/corelow.c b/gdb/corelow.c > index eb785a08633..711e86c4cd4 100644 > --- a/gdb/corelow.c > +++ b/gdb/corelow.c > @@ -428,7 +428,8 @@ core_target_open (const char *arg, int from_tty) > } > > gdb::unique_xmalloc_ptr filename (tilde_expand (arg)); > - if (!IS_ABSOLUTE_PATH (filename.get ())) > + if (strlen (filename.get ()) != 0 > + && !IS_ABSOLUTE_PATH (filename.get ())) > filename = gdb_abspath (filename.get ()); > > flags = O_BINARY | O_LARGEFILE; > diff --git a/gdb/testsuite/gdb.base/batch-exit-status.exp b/gdb/testsuite/gdb.base/batch-exit-status.exp > index 085dfc6ad56..9a080196bd6 100644 > --- a/gdb/testsuite/gdb.base/batch-exit-status.exp > +++ b/gdb/testsuite/gdb.base/batch-exit-status.exp > @@ -76,3 +76,7 @@ test_exit_status 1 "-batch -x $good_commands -x $bad_commands" \ > "-batch -x good-commands -x bad-commands" > test_exit_status 1 "-batch -x $good_commands -ex \"set not-a-thing 4\"" \ > "-batch -x good-commands -ex \"set not-a-thing 4\"" > + > +set no_such_re ": No such file or directory\\." > +test_exit_status 1 "-batch \"\"" $no_such_re > +test_exit_status 1 "-batch \"\" \"\"" [multi_line $no_such_re $no_such_re]