From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id oD2jKSSVI2FpLgAAWB0awg (envelope-from ) for ; Mon, 23 Aug 2021 08:31:32 -0400 Received: by simark.ca (Postfix, from userid 112) id A8D2C1EE18; Mon, 23 Aug 2021 08:31:32 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 3FF571E79C for ; Mon, 23 Aug 2021 08:31:32 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A167A3857432 for ; Mon, 23 Aug 2021 12:31:31 +0000 (GMT) Received: from mail-wr1-x430.google.com (mail-wr1-x430.google.com [IPv6:2a00:1450:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 6476D3858417 for ; Mon, 23 Aug 2021 12:31:11 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6476D3858417 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wr1-x430.google.com with SMTP id z4so10414226wrr.6 for ; Mon, 23 Aug 2021 05:31:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=9Meq5ucawLKEpGi7Nt0aLuycT2Z/F/cTtLE/WLePAbQ=; b=atl5kJbOFo8SAohY2cbaaT14zPF4pT4bL9xlJM5imT8YxLVDRY+UIo8WQ3tKbOLdsp +VOK9xDSXBpc5r5of6Mq7lsA0IJmdaIaPtnY5Bo0iAsIjJ/+hjvKcHMCVsueDdsJieWV 9PkXyWbBU+rltSpkzgk+mW+SNBH3LhVoYrDwLqzywUhRLUrJPhoZOZA9biW4uH8PQP3P jcPKQKlh/01645JkweaemU9KTHrVwG7muc1DpdCs9iUKdEDB554e/okFkfN71sHK9NKY NgRK7qtDe4gMNR2CJhRtSYbBBrICIJIOB+X6i8dUht6YK0SI/Ex0U/s8SNo4F/Gf/VIZ uemQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=9Meq5ucawLKEpGi7Nt0aLuycT2Z/F/cTtLE/WLePAbQ=; b=uJ3VJlWmTfGIuLP6QMMusavZQLkpdDpYAvPntjSMswIqPF6YunJcKFu47KQJs2a/5g sUGW/JxzEZygEBcfbiWLAPCIFdsU5aZ/Nlc6i9yFqBR9AcKXwy8XpzljB6vn3SxItoO+ jzTOVlBdOP6f8yIo+P+NM3XfFL8wmSXylhkmOtJMLuhtM+5I6MLoxg1Hvn3c8HREoPlk nD7azm+vxD5tNF4Ad7nlAG4ACGVlZ0puLh1PZEz6YxV6dRHalmii7IarL7jzTZwhWqFr 7UF1INpPu1KRWP53OeD3I7MlE4cmZsZrK3riwyHQ+OPznd/43BDA3FMmHyPsqE2sV+0L csWw== X-Gm-Message-State: AOAM53333v3G04Eb8KW0JOJOk6AeD7Mc/UIRJo8ojjenv38/o7WZzoBG I60Ei1Az0oUvybFi54lOstXDPQ== X-Google-Smtp-Source: ABdhPJz5mr5WYjWBxUbLpDCF/2IN2yK4EyvEf9BvjZSrvNNeFLqGH1ips58H8W9IwtUwnilQzscUvQ== X-Received: by 2002:a5d:4ac2:: with SMTP id y2mr11850870wrs.296.1629721870404; Mon, 23 Aug 2021 05:31:10 -0700 (PDT) Received: from localhost (host86-188-49-44.range86-188.btcentralplus.com. [86.188.49.44]) by smtp.gmail.com with ESMTPSA id c13sm10977534wru.73.2021.08.23.05.31.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 05:31:09 -0700 (PDT) Date: Mon, 23 Aug 2021 13:31:09 +0100 From: Andrew Burgess To: Pedro Alves Subject: Re: [PATCHv5] gdb: prevent an assertion when computing the frame_id for an inline frame Message-ID: <20210823123109.GD2581@embecosm.com> References: <20210727101003.2910993-1-andrew.burgess@embecosm.com> <20210809154122.3468792-1-andrew.burgess@embecosm.com> <20210823094159.GC2581@embecosm.com> <87ce1eab-aba1-7282-97cd-89233e3d7f54@palves.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87ce1eab-aba1-7282-97cd-89233e3d7f54@palves.net> X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:27:46 up 6 days, 1:23, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Pedro Alves [2021-08-23 11:26:49 +0100]: > Hi Andrew, > > Sorry I hadn't responded yet. I was out on vacation a few weeks ago, and thought I would be able to > get to this once I got back, but I got immediately pulled to a tight internal deadline instead. FWIW, I've > been very frustrated about failing to reply to you. I should be able to take a look this week, though. > > On 2021-08-23 10:41 a.m., Andrew Burgess wrote: > > Ping! > > > > Simon, what are your thoughts on this approach? From what I recall of > > our discussion on IRC your concerns with my original patch were that > > after my change the function implementation no longer matched with the > > function name, this made GDB's internal APIs confusing and > > inconsistent. > > > > With this patch I've tried to avoid this by renaming the functions to > > hopefully make the API clearer. > > > > I'm just guessing, but I suspect it was the use of exceptions that > > Pedro wasn't happy with, so maybe if you're happy with this latest > > patch we could merge this change, given Pedro already approved the > > pre-exception patch. > > I don't recall the discussion with Simon, but yes, use custom exceptions > for this doesn't sound great to me. Let me take a better look. Thanks for taking the time to reply. I completely understand other pressures getting in the way of being as active on the m/l. Even just knowing for sure which part of the patch you didn't like is great information as I can start coming up with alternatives. So I'm always grateful for any feedback, no matter how terse. Thanks again, Andrew