Re: [PATCH] Notify observer of breakpoint auto-disabling

Simon Marchi via Gdb-patches
2021-08-16T14:05:20Z

On 2021-08-16 8:44 a.m., Patrick Monnerat via Gdb-patches wrote:
> As breakpoint_modified observer is currently notified upon breakpoint stop
> before handling auto-disabling when enable count is reached, the observer
> is never notified of the disabling.
>
> The problem affects:
> - The MI interpreter enabled= value when reporting =breakpoint-modified
> - A Python event handler for breakpoint_modified using the "enabled"
> member of its parameter
> - insight: breakpoint GUI window is not properly updated upon auto-disable
>
> This patch moves the observer notification after the auto-disabling
> code and implements corresponding tests for the MI and Python cases.
>
> Fixes https://sourceware.org/bugzilla/show_bug.cgi?id=23336

Thanks, this is ok to push. Do you have push access? Would you like to
push this on your behalf?

Simon