From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +OfiHk/iBmFNKgAAWB0awg (envelope-from ) for ; Sun, 01 Aug 2021 14:05:03 -0400 Received: by simark.ca (Postfix, from userid 112) id 7CC4F1EDFB; Sun, 1 Aug 2021 14:05:03 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DC1AB1EA7E for ; Sun, 1 Aug 2021 14:05:02 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 9FBC1386482A for ; Sun, 1 Aug 2021 18:05:02 +0000 (GMT) Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id ECB0E385801A for ; Sun, 1 Aug 2021 18:04:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ECB0E385801A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 358921FEA9 for ; Sun, 1 Aug 2021 18:04:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627841090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=UJgiowmKd77DIVowlWQxZ4A2jzIH7uhzVFE3GYG8TJg=; b=R3RhPyVbeota+lPg1SlHAuJc4cSPQpmvr7cz5TNG2IUUy2OapczBHaaT9n+UX+tmt0yeKd 4h7FuwNHwZ0peQixbq0M7yzWRR9GiaGqmyNNJ0qCbCH8BthATWPPTZhCs7zVqNY8VbNwcm qRLKD4iQK1dfZOaQMfOzSQc411TwY04= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627841090; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type; bh=UJgiowmKd77DIVowlWQxZ4A2jzIH7uhzVFE3GYG8TJg=; b=mZ2CMy7Az9XTkDV6RGaN563P+UFB4wGIOaqIerzYRzElqJ3CnJmYuf6bu08Faq4HPf9zDF 0w6SVd1oY6JWekCQ== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id 237401369B for ; Sun, 1 Aug 2021 18:04:50 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id peWiB0LiBmHFcwAAGKfGzw (envelope-from ) for ; Sun, 01 Aug 2021 18:04:50 +0000 Date: Sun, 1 Aug 2021 20:04:48 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Fix gdb.base/index-cache.exp with cc-with-gdb-index Message-ID: <20210801180446.GA9266@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, With target board cc-with-gdb-index we run into: ... FAIL: gdb.base/index-cache.exp: couldn't remove files in temporary cache dir ... The problem is that there are no files to remove, because the index cache isn't used, as indicated by $expecting_index_cache_use. Fix this by only FAILing when $expecting_index_cache_use. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Fix gdb.base/index-cache.exp with cc-with-gdb-index gdb/testsuite/ChangeLog: 2021-08-01 Tom de Vries * gdb.base/index-cache.exp: --- gdb/testsuite/gdb.base/index-cache.exp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gdb/testsuite/gdb.base/index-cache.exp b/gdb/testsuite/gdb.base/index-cache.exp index 0daf7bbb086..496145ed8fc 100644 --- a/gdb/testsuite/gdb.base/index-cache.exp +++ b/gdb/testsuite/gdb.base/index-cache.exp @@ -227,7 +227,7 @@ test_cache_enabled_hit $cache_dir test_cache_disabled $cache_dir "after populate" lassign [remote_exec host sh "-c \"rm $cache_dir/*.gdb-index\""] ret -if { $ret != 0 } { +if { $ret != 0 && $expecting_index_cache_use } { fail "couldn't remove files in temporary cache dir" return }