From: Joel Brobecker <brobecker@adacore.com>
To: Simon Marchi <simon.marchi@polymtl.ca>
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Luis Machado via Gdb-patches <gdb-patches@sourceware.org>,
Joel Brobecker <brobecker@adacore.com>,
david.spickett@linaro.org
Subject: Re: [PING][PATCH,v5][AArch64] MTE corefile support
Date: Sun, 1 Aug 2021 08:44:05 -0700 [thread overview]
Message-ID: <20210801154405.GA471794@adacore.com> (raw)
In-Reply-To: <7d85da38-1e88-1f1f-77fa-15dbe483538b@polymtl.ca>
> On 2021-07-29 2:10 p.m., Catalin Marinas wrote:
> > I'm more worried about GDB 11 reading the MTE notes incorrectly rather
> > than not reading them at all.
>
> Yeah, if a GDB 11 that knows how to read the pre-standardized notes does
> not fail gracefully when encountering the standardized notes, it would
> be bad. If it just skipped them and said "I don't recognize them", it
> would be ok.
Agreed.
Is there a way we could check the notes? I looked at the patch,
and it doesn't seem like there is any kind of versioning or
identifier we could use to determine which version of the notes
we get. But perhaps we can at least do some kind of consistency
check, such as for instance comparing the size of the section
with the contents of the section header, and generate an error
if that doesn't match. The error might not be as informative,
but perhaps still good enough?
> Oh, ok, I thought it had already gone through some review cycles. Then
> I'll leave it to you all to decide, those who have some stakes in this.
--
Joel
next prev parent reply other threads:[~2021-08-01 15:44 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 20:20 [PATCH] [AArch64] " Luis Machado via Gdb-patches
2021-05-19 10:01 ` David Spickett via Gdb-patches
2021-05-19 11:11 ` Luis Machado via Gdb-patches
2021-05-19 12:13 ` Eli Zaretskii via Gdb-patches
2021-05-21 15:12 ` Alan Hayward via Gdb-patches
2021-05-21 15:30 ` Luis Machado via Gdb-patches
2021-05-21 17:20 ` John Baldwin
2021-05-24 13:41 ` Luis Machado via Gdb-patches
2021-05-24 8:07 ` Alan Hayward via Gdb-patches
2021-05-24 12:45 ` Luis Machado via Gdb-patches
2021-05-26 14:08 ` [PATCH,v2] " Luis Machado via Gdb-patches
2021-05-29 3:14 ` Simon Marchi via Gdb-patches
2021-05-31 14:12 ` Luis Machado via Gdb-patches
2021-05-31 14:49 ` Simon Marchi via Gdb-patches
2021-05-31 14:56 ` Luis Machado via Gdb-patches
2021-05-31 14:15 ` [PATCH,v3][AArch64] " Luis Machado via Gdb-patches
2021-05-31 16:44 ` [PATCH,v4][AArch64] " Luis Machado via Gdb-patches
2021-06-01 17:45 ` [PATCH,v5][AArch64] " Luis Machado via Gdb-patches
2021-06-15 14:10 ` [Ping][PATCH,v5][AArch64] " Luis Machado via Gdb-patches
2021-06-24 14:00 ` [PATCH,v5][AArch64] " Alan Hayward via Gdb-patches
2021-06-24 14:37 ` Luis Machado via Gdb-patches
2021-06-24 15:18 ` Alan Hayward via Gdb-patches
2021-07-01 13:50 ` [PING][PATCH,v5][AArch64] " Luis Machado via Gdb-patches
2021-07-11 14:22 ` Joel Brobecker
2021-07-14 13:07 ` Catalin Marinas via Gdb-patches
2021-07-29 2:26 ` Simon Marchi via Gdb-patches
2021-07-29 16:03 ` John Baldwin
2021-07-29 18:10 ` Catalin Marinas via Gdb-patches
2021-07-29 18:20 ` Simon Marchi via Gdb-patches
2021-08-01 15:44 ` Joel Brobecker [this message]
2021-08-02 12:06 ` Luis Machado via Gdb-patches
2021-07-19 19:05 ` Luis Machado via Gdb-patches
2021-07-27 16:10 ` Luis Machado via Gdb-patches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210801154405.GA471794@adacore.com \
--to=brobecker@adacore.com \
--cc=catalin.marinas@arm.com \
--cc=david.spickett@linaro.org \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox