From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id fqSiMoYgAGFPfAAAWB0awg (envelope-from ) for ; Tue, 27 Jul 2021 11:04:38 -0400 Received: by simark.ca (Postfix, from userid 112) id BEA8A1EDFB; Tue, 27 Jul 2021 11:04:38 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id DC6C41E79C for ; Tue, 27 Jul 2021 11:04:37 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 662923840031 for ; Tue, 27 Jul 2021 15:04:37 +0000 (GMT) Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id BE5E8384BC22 for ; Tue, 27 Jul 2021 15:04:07 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BE5E8384BC22 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D872A221F0; Tue, 27 Jul 2021 15:04:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1627398246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=LUT7z9qcGeOXl5fbdFJ9VXH0sj+A2GKxvORXZ9007xU=; b=oIf56DXO4JaHzG9nDgzIwcj9a6ZhYMYV5tHnvLdMUX5slw5vgMEDUbPBpgZdVhm97Cu5LH JoabMGkiT7n0SpTXPDSRddHkKMujO/AbkLIwMmWHJt3l25VfdsNdbG17ssmuy1jv8qYE2e DPtaFyAlqh94/2ATqh6YxKWp/xTn8xs= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1627398246; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type; bh=LUT7z9qcGeOXl5fbdFJ9VXH0sj+A2GKxvORXZ9007xU=; b=rRLMdvuoUsAsjv53srpD1H3RpAYhW01StiSJO82De9b5EWAqjdBM9Hr4EhwQ77D2ttTS2j 8W/kiwfERU+J08Aw== Received: from imap1.suse-dmz.suse.de (imap1.suse-dmz.suse.de [192.168.254.73]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap1.suse-dmz.suse.de (Postfix) with ESMTPS id BBDBB13CF4; Tue, 27 Jul 2021 15:04:06 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap1.suse-dmz.suse.de with ESMTPSA id JmviLGYgAGGGGQAAGKfGzw (envelope-from ); Tue, 27 Jul 2021 15:04:06 +0000 Date: Tue, 27 Jul 2021 17:04:05 +0200 From: Tom de Vries To: gdb-patches@sourceware.org Subject: [committed][gdb/testsuite] Add xfail for PR gcc/101633 Message-ID: <20210727150404.GA18280@delia> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi, With gcc 7.5.0, I run into: ... (gdb) print objects^M $1 = ((tag => object, values => ()), (tag => unused))^M (gdb) FAIL: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array ... while with gcc 8.5.0 we have: ... (gdb) print objects^M $1 = ((tag => object, values => (2, 2, 2, 2, 2)), (tag => unused))^M (gdb) PASS: gdb.ada/array_of_variant.exp: scenario=minimal: print entire array ... This is due to a gcc PR, which I've filed at https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101633 "Bug 101633 - [debug] DW_TAG_subrange_type missing DW_AT_upper_bound". Fix by marking this and related FAILs as XFAIL. Tested on x86_64-linux. Committed to trunk. Thanks, - Tom [gdb/testsuite] Add xfail for PR gcc/101633 gdb/ChangeLog: 2021-07-27 Tom de Vries PR testsuite/26903 * gdb/testsuite/gdb.ada/array_of_variant.exp: Add xfails. --- gdb/testsuite/gdb.ada/array_of_variant.exp | 53 +++++++++++++++++++++++------- 1 file changed, 42 insertions(+), 11 deletions(-) diff --git a/gdb/testsuite/gdb.ada/array_of_variant.exp b/gdb/testsuite/gdb.ada/array_of_variant.exp index d93ad4704a0..6372e2cf354 100644 --- a/gdb/testsuite/gdb.ada/array_of_variant.exp +++ b/gdb/testsuite/gdb.ada/array_of_variant.exp @@ -20,6 +20,29 @@ if { [skip_ada_tests] } { return -1 } standard_ada_testfile p +if [get_compiler_info] { + return -1 +} +set old_gcc [expr [test_compiler_info {gcc-[0-7]-*}]] + +proc gdb_test_with_xfail { cmd re re_xfail msg } { + global scenario old_gcc + set have_xfail [expr $old_gcc && [string equal "$scenario" "minimal"]] + + gdb_test_multiple $cmd $msg { + -re -wrap $re { + pass $gdb_test_name + } + -re -wrap $re_xfail { + if { $have_xfail } { + # gcc/101633 + setup_xfail *-*-* + } + fail $gdb_test_name + } + } +} + foreach_with_prefix scenario {all minimal} { set flags [list debug additional_flags=-fgnat-encodings=$scenario] @@ -33,17 +56,23 @@ foreach_with_prefix scenario {all minimal} { runto "p.adb:$bp_location" set v1 "(tag => object, values => (2, 2, 2, 2, 2))" + set v1_xfail "(tag => object, values => ())" set v2 "(tag => unused)" - gdb_test "print objects" \ - [string_to_regexp " = ($v1, $v2)"] \ - "print entire array" - gdb_test "print objects(1)" \ - [string_to_regexp " = $v1"] \ + set re [string_to_regexp " = ($v1, $v2)"] + set re_xfail [string_to_regexp " = ($v1_xfail, $v2)"] + gdb_test_with_xfail "print objects" $re $re_xfail "print entire array" + + set re [string_to_regexp " = $v1"] + set re_xfail [string_to_regexp " = $v1_xfail"] + gdb_test_with_xfail "print objects(1)" $re $re_xfail \ "print first array element" - gdb_test "print objects(1 .. 1)" \ - [string_to_regexp " = ($v1)"] \ + + set re [string_to_regexp " = ($v1)"] + set re_xfail [string_to_regexp " = ($v1_xfail)"] + gdb_test_with_xfail "print objects(1 .. 1)" $re $re_xfail \ "print first array slice" + gdb_test "print objects(2)" \ [string_to_regexp " = $v2"] \ "print second array element" @@ -56,11 +85,13 @@ foreach_with_prefix scenario {all minimal} { gdb_test_no_output \ "python o = gdb.parse_and_eval('objects')" \ "fetch value for python" - gdb_test "python print(o)" \ - [string_to_regexp "($v1, $v2)"] \ + set re [string_to_regexp "($v1, $v2)"] + set re_xfail [string_to_regexp "($v1_xfail, $v2)"] + gdb_test_with_xfail "python print(o)" $re $re_xfail \ "python print array" - gdb_test "python print(o\[1\])" \ - [string_to_regexp "$v1"] \ + set re [string_to_regexp "$v1"] + set re_xfail [string_to_regexp "$v1_xfail"] + gdb_test_with_xfail "python print(o\[1\])" $re $re_xfail \ "python print first array element" gdb_test "python print(o\[2\])" \ [string_to_regexp "$v2"] \