From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id GroxN+m2/mA7VwAAWB0awg (envelope-from ) for ; Mon, 26 Jul 2021 09:21:45 -0400 Received: by simark.ca (Postfix, from userid 112) id D18381EDFB; Mon, 26 Jul 2021 09:21:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id CA7FB1E813 for ; Mon, 26 Jul 2021 09:21:44 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5F06F389F4EF for ; Mon, 26 Jul 2021 13:21:44 +0000 (GMT) Received: from mail-wm1-x32c.google.com (mail-wm1-x32c.google.com [IPv6:2a00:1450:4864:20::32c]) by sourceware.org (Postfix) with ESMTPS id 78E51384803C for ; Mon, 26 Jul 2021 13:21:32 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 78E51384803C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x32c.google.com with SMTP id l4-20020a05600c1d04b02902506f89ad2dso2144646wms.1 for ; Mon, 26 Jul 2021 06:21:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=n1mVEWmXFEzIshu3J/SlPmyL0S6wbSWiU+GZu/9NWQE=; b=gIfqwlKtIa84MrHvLlBiZBqvQly8KdzI4KPL5I4tconzKj1IjTRW43Jdddt/YNoKjT YZHLPmePhXFMQ7WewUVzAS/s0+72Sc4nanCJp6yNNCaPL7EUhvdB9RmALRq435QYMKUv UFWe+BgAkE4puUMpds6r3TxptULAonrgLFzR3VE0EfLlU7jQNeyOwhzpcVgy1x1KchH6 v3UhTU3hCAa77t2OiepeqZsatE6IzJfl/r8b4kNv/n+iB79hzbTaoepQV2Rh7LJ5CtPs FxXtMzh0PzItx+s2qUSLlRvNCtG7mxGEtFBfsGMfQArvWXfEPKfPeC0udEL9lmdolSIo E2kg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=n1mVEWmXFEzIshu3J/SlPmyL0S6wbSWiU+GZu/9NWQE=; b=DpnnQ/A9lo+9lnfK8cBde1MJwMWYsSuCfwz6h0V1RgZb4bVaKnSwhKcsOqvShAe7WJ 0e9kmDzRav3Y3pucXkwjX5hjs5kYDPMwq5L8qNT3AUNZQ9REyVyPDwS7Y/lfz2g8I0Fg J1nImePgGrBzA/aFd05mFjK0VWLQfg517x/Dd5hPfl8EpQP1lcZ9J1lFy6HK3ygUOegc mt023Hg4OQXzvP7v8P4wVQJMR0Im6dGsYItPgQ3FasxN64q5gtuhCyQf98zddivGR215 RH1Vksl+3kghpJ9Db5426S9Wzc3G/zx+HTu8AmH5eMXxxNsq0QvNiXdY3yHBsyWqxHbc //pg== X-Gm-Message-State: AOAM532dcKddjEaViaXAgbeLpNZwkAYgWmWirfjjIa/EvshM6hHgvfDa wWfwjOpuPobtQd09Q41suvRfNg== X-Google-Smtp-Source: ABdhPJwA0oAhW3yK8JrX/1aLCf1PxhNlfRmvYI75J8yAnYm4iYKf6AIVuTpfvkvMSnVhu7qhz1bRiA== X-Received: by 2002:a7b:c042:: with SMTP id u2mr16947008wmc.86.1627305691602; Mon, 26 Jul 2021 06:21:31 -0700 (PDT) Received: from localhost (host86-161-16-194.range86-161.btcentralplus.com. [86.161.16.194]) by smtp.gmail.com with ESMTPSA id e5sm5355621wrr.36.2021.07.26.06.21.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Jul 2021 06:21:31 -0700 (PDT) Date: Mon, 26 Jul 2021 14:21:30 +0100 From: Andrew Burgess To: Tom de Vries Subject: Re: [PATCHv3 2/5] gdb: make struct output_source_filename_data more C++ like Message-ID: <20210726132130.GK1872618@embecosm.com> References: <44f3bcb87067e98b6ff670e133b366a902cc69ab.1623090529.git.andrew.burgess@embecosm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 14:18:20 up 9 days, 23:52, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gdb-patches@sourceware.org Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" * Tom de Vries [2021-07-05 14:31:22 +0200]: > On 6/7/21 8:32 PM, Andrew Burgess wrote: > > +bool > > +info_sources_filter::matches (const char *fullname) const > > +{ > > + /* Does it match regexp? */ > > + if (m_c_regexp.has_value ()) > > + { > > + const char *to_match; > > + std::string dirname; > > + > > + switch (m_match_type) > > + { > > + case match_on::DIRNAME: > > + dirname =3D ldirname (fullname); > > + to_match =3D dirname.c_str (); > > + break; > > + case match_on::BASENAME: > > + to_match =3D lbasename (fullname); > > + break; > > + case match_on::FULLNAME: > > + to_match =3D fullname; > > + break; > > + } > > + > > + if (m_c_regexp->exec (to_match, 0, NULL, 0) !=3D 0) > > + return false; > > + } > > + > > + return true; > > +} >=20 > When compiling with -O2, I run into: > ... > src/gdb/symtab.c: In member function =E2=80=98bool > info_sources_filter::matches(const char*) const=E2=80=99: > src/gdb/symtab.c:4247:28: warning: =E2=80=98to_match=E2=80=99 may be used= uninitialized > in this function [-Wmaybe-uninitialized] > 4247 | if (m_c_regexp->exec (to_match, 0, NULL, 0) !=3D 0) > | ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~ > ... Sorry I missed this. Tom Tromey fixed this with this commit: commit b6aeb717a8bdaa9cc348ec88a5fdf059e1337580 Author: Tom Tromey Date: Mon Jul 5 11:44:54 2021 -0600 Fix warning in symtab.c Thanks, Andrew