From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 23u7OSbY22AnPQAAWB0awg (envelope-from ) for ; Tue, 29 Jun 2021 22:34:14 -0400 Received: by simark.ca (Postfix, from userid 112) id D8F1D1F1F2; Tue, 29 Jun 2021 22:34:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 479321EE14 for ; Tue, 29 Jun 2021 22:34:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CB63E386EC51 for ; Wed, 30 Jun 2021 02:34:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org CB63E386EC51 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1625020453; bh=YTxX+1fOkS5J/fgE9TkrSvwIOOmmiDGWpD7NkZq+Hno=; h=To:Subject:Date:In-Reply-To:References:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=yQD5e+79jr42AC1l47hrvkb5C9dJ7cpBF14sX6y98Jo0Tp3l4zXZCf15HbGUd/lN8 1KAup1zrLIAWgLYTnEzaDJ4zdj8N9CghBxMYcS0lO8FMImKv9/LpVG0e/bc5yKC5H8 oevwrvMXDX96/xsVAZzfWawLMghaL9O+V8IbuVcA= Received: from smtp.gentoo.org (dev.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id BDD8E3847800 for ; Wed, 30 Jun 2021 02:33:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org BDD8E3847800 Received: from vapier.lan (localhost [127.0.0.1]) by smtp.gentoo.org (Postfix) with ESMTP id ACA58335D46 for ; Wed, 30 Jun 2021 02:33:53 +0000 (UTC) To: gdb-patches@sourceware.org Subject: [PATCH] sim: ppc: fix printf warnings Date: Tue, 29 Jun 2021 22:33:51 -0400 Message-Id: <20210630023351.25490-1-vapier@gentoo.org> X-Mailer: git-send-email 2.31.1 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Mike Frysinger via Gdb-patches Reply-To: Mike Frysinger Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" This code hits some format-zero-length warnings, so hack the code like we did in the common layers. --- sim/ppc/ChangeLog | 6 ++++++ sim/ppc/main.c | 2 ++ sim/ppc/sim_calls.c | 10 ++++++++-- 3 files changed, 16 insertions(+), 2 deletions(-) diff --git a/sim/ppc/ChangeLog b/sim/ppc/ChangeLog index b41d20230d95..7a23d68842bd 100644 --- a/sim/ppc/ChangeLog +++ b/sim/ppc/ChangeLog @@ -1,3 +1,9 @@ +2021-06-29 Mike Frysinger + + * main.c (sim_io_error): Add comment + * sim_calls.c (sim_io_error): Likewise. Change "" to " ". + (error): Likewise. + 2021-06-20 Mike Frysinger * Makefile.in (INLINE_CFLAGS): Change to $(SIM_INLINE). diff --git a/sim/ppc/main.c b/sim/ppc/main.c index 0c1a070fc2c2..2d4d7e402753 100644 --- a/sim/ppc/main.c +++ b/sim/ppc/main.c @@ -214,6 +214,8 @@ sim_io_flush_stdoutput(void) } } +/* Glue to use sim-fpu module. */ + void sim_io_error (SIM_DESC sd, const char *msg, ...) { diff --git a/sim/ppc/sim_calls.c b/sim/ppc/sim_calls.c index 14d4d6586c78..ee9d123b1872 100644 --- a/sim/ppc/sim_calls.c +++ b/sim/ppc/sim_calls.c @@ -372,6 +372,8 @@ sim_io_flush_stdoutput(void) } } +/* Glue to use sim-fpu module. */ + void sim_io_error (SIM_DESC sd, const char *fmt, ...) { @@ -379,7 +381,9 @@ sim_io_error (SIM_DESC sd, const char *fmt, ...) va_start(ap, fmt); callbacks->evprintf_filtered (callbacks, fmt, ap); va_end(ap); - callbacks->error (callbacks, ""); + /* Printing a space here avoids empty printf compiler warnings. Not ideal, + but we want error's side-effect where it halts processing. */ + callbacks->error (callbacks, " "); } /****/ @@ -391,7 +395,9 @@ error (const char *msg, ...) va_start(ap, msg); callbacks->evprintf_filtered (callbacks, msg, ap); va_end(ap); - callbacks->error (callbacks, ""); + /* Printing a space here avoids empty printf compiler warnings. Not ideal, + but we want error's side-effect where it halts processing. */ + callbacks->error (callbacks, " "); } void * -- 2.31.1