> On 2021-06-13 11:10 a.m., Joel Brobecker wrote: > > - For patches with multiple authors, we ask that commits with > > multiple authors have a... > > > > Co-Authored-By: xxx > > > > ... git-trailer, so that complete author information be kept. > > Similar to that, I was wondering if we should define a standard method > to refer to a bug/PR number in a git trailer. For example, for a commit > fixing an issue: > > Fixes: PR gdb/1234 > > Sometimes, you make a commit that is related to a PR but does not fix it > (for example, add a KFAIL-ed test). In that case, it should be > something else than "Fixes". What about... Bug: PR gdb/1234 ... or... Xref: PR gdb/1234 ? > What do people use normally for thse things? Is it necessary, or just > mentioning "PR gdb/1234" somewhere in the commit message's free text > will be enough to automatically link the commit to the PR? I believe so. FTAOD, here is the sequence in the script which extracts the references to bugzilla PR numbers: while ($log_txt =~ m/\s(?:bug|PR|BZ)\s+\#?\s*(?:[a-z0-9+-]+\/)?(?:\/)?(\d+)(.*)$/si) { Let me also attach a copy of the entire script, just in case I missed something. Regardless of the above, I think it would be nice if we used Git trailers for this as it makes it easier to find that kind of information. -- Joel