From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Ug6XFC6A0GBdOgAAWB0awg (envelope-from ) for ; Mon, 21 Jun 2021 08:03:58 -0400 Received: by simark.ca (Postfix, from userid 112) id 4B6091F1F2; Mon, 21 Jun 2021 08:03:58 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 74AC31E54D for ; Mon, 21 Jun 2021 08:03:57 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 3037E393AC1F for ; Mon, 21 Jun 2021 12:03:57 +0000 (GMT) Received: from mail-wm1-x335.google.com (mail-wm1-x335.google.com [IPv6:2a00:1450:4864:20::335]) by sourceware.org (Postfix) with ESMTPS id 93B5D3938C33 for ; Mon, 21 Jun 2021 12:02:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 93B5D3938C33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=embecosm.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=embecosm.com Received: by mail-wm1-x335.google.com with SMTP id k42so8443439wms.0 for ; Mon, 21 Jun 2021 05:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=embecosm.com; s=google; h=date:from:to:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=r6pp8MtaiwWEliAhhWMfpXWuxObgW2XistATMXLIlsg=; b=OM+7BuhCEf7FIbPoa8eAIVGFywSMmec02/ULTXns62EUsHKDJYGChjvgMkkp5ACa1n n+jc778wLiYw1D/B2/NsIRmHaT1MkKsCanrmXPmwZihi30oukZQh1cJ/TcWPdUJMcMxy UkPEsH+6WngV8cIS5oEtTM6SOgJG20EUd8UUyiJ1zh3ZqjYvE2ia36lb8wYBcVpT5aCw DVoDuC+zU8lEAatNa1GaQl2silShBbKJSUyHy23AfcIVOyCbHoxe4PCSiBc0B7QVuhCL /M+v61qP50+TN/zl1i9TYlb84N1ym9DhhW2bSTwD+g5C4JI19oc9f7fZr16ZFf6b7GVa Jd/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=r6pp8MtaiwWEliAhhWMfpXWuxObgW2XistATMXLIlsg=; b=Df0/12DKdNTMrd5ienvn63eV2NwHPfRqSMPESHBQBG7bEmP5HdhQZ/bYvY/CossHAh Rvt9ZWo5UOb0crEgpnQ0gT0vxjV8kHFPDNhU74VWkje3uoIP9HbcdCMazzWlZBC00+zC FIiUzW/5TAaAlLG8gIL+Pz3Kidn67abq2yIOuSDoM3N+74FKom6dBuHK62VlMmNU4Ec/ 1Hxf8/QF5yd3bIwtudNamcsaT502P958TVISadKFPVgBKp1AROyJgyjrFWvgFA/8YCns JxpvAwdvv9ZjGzCOiPlFkxa8v1kacKty+zsdw5gZ/HgwNXbk4nJiCtrxrcUIA7M40fLa C4zA== X-Gm-Message-State: AOAM533TXqBiuk6JJbut5TEHA5GnAIfMFkRsnVnJVSKEDVlfIzPRNTUf hwqkh9pKoTSaGal8apxw4cXQFvlA5knntyHR X-Google-Smtp-Source: ABdhPJyxz6ktYimW4dC3cYQf5162737c5niyYAcErpt8a9Nbt6ZOOwiPBSnhT5aauCimGNMoQ75DUQ== X-Received: by 2002:a05:600c:1c22:: with SMTP id j34mr27657400wms.166.1624276923134; Mon, 21 Jun 2021 05:02:03 -0700 (PDT) Received: from localhost (host86-140-92-85.range86-140.btcentralplus.com. [86.140.92.85]) by smtp.gmail.com with ESMTPSA id l10sm17081176wrs.11.2021.06.21.05.02.02 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Jun 2021 05:02:02 -0700 (PDT) Date: Mon, 21 Jun 2021 13:02:01 +0100 From: Andrew Burgess To: gdb-patches@sourceware.org Subject: PING! Re: [PATCHv3 0/5] "info sources" - group by objfile Message-ID: <20210621120201.GC2568@embecosm.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Operating-System: Linux/5.8.18-100.fc31.x86_64 (x86_64) X-Uptime: 13:00:57 up 4 days, 19:52, X-Editor: GNU Emacs [ http://www.gnu.org/software/emacs ] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" I plan to push v3 later this week. The first two versions of this patch have had no negative feedback, and the changes in v3 are minor over v2. Thanks, Andrew * Andrew Burgess [2021-06-07 19:32:22 +0100]: > In V3: > > - 'info sources' now indicates when an objfile has no debug > information at all, this is a slight change of code, and an update > to the commit message in patch #5. > > - the MI output is updated to include the same information, there are > code changes, an update of the commit message, and changes to the > documentation in patch #4. > > - all the other patches are unchanged. > > Thanks, > Andrew > > > --- > > Andrew Burgess (5): > gdb: add new function quick_symbol_functions::has_unexpanded_symbols > gdb: make struct output_source_filename_data more C++ like > gdb/mi: add regexp filtering to -file-list-exec-source-files > gdb/mi: add new --group-by-objfile flag for > -file-list-exec-source-files > gdb: change info sources to group results by objfile > > gdb/ChangeLog | 111 ++++++ > gdb/NEWS | 31 ++ > gdb/doc/ChangeLog | 15 + > gdb/doc/gdb.texinfo | 176 +++++++-- > gdb/dwarf2/read.c | 22 ++ > gdb/mi/mi-cmd-file.c | 92 +++-- > gdb/objfiles.h | 6 + > gdb/psympriv.h | 2 + > gdb/psymtab.c | 18 + > gdb/quick-symbol.h | 6 + > gdb/symfile-debug.c | 25 ++ > gdb/symtab.c | 364 ++++++++++++------ > gdb/symtab.h | 59 +++ > gdb/testsuite/ChangeLog | 19 + > .../gdb.base/info_sources_2-header.h | 28 ++ > gdb/testsuite/gdb.base/info_sources_2-lib.c | 25 ++ > gdb/testsuite/gdb.base/info_sources_2-test.c | 26 ++ > gdb/testsuite/gdb.base/info_sources_2.exp | 169 ++++++++ > gdb/testsuite/gdb.dwarf2/dw2-filename.exp | 2 +- > gdb/testsuite/gdb.mi/mi-file.exp | 2 +- > gdb/testsuite/gdb.mi/mi-info-sources-base.c | 23 ++ > gdb/testsuite/gdb.mi/mi-info-sources.c | 25 ++ > gdb/testsuite/gdb.mi/mi-info-sources.exp | 184 +++++++++ > 23 files changed, 1239 insertions(+), 191 deletions(-) > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-header.h > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-lib.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2-test.c > create mode 100644 gdb/testsuite/gdb.base/info_sources_2.exp > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources-base.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.c > create mode 100644 gdb/testsuite/gdb.mi/mi-info-sources.exp > > -- > 2.25.4 >