Re: [PATCH v2 05/12] python: Introduce gdb.RecordAuxiliary class.

Eli Zaretskii via Gdb-patches
2021-06-14T15:52:07Z

> Date: Mon, 14 Jun 2021 16:54:04 +0200
> From: Felix Willgerodt via Gdb-patches <gdb-patches@sourceware.org>
>
> Auxiliary instructions are no real instructions and get their own object
> class, similar to gaps. gdb.Record.instruction_history is now possibly a
> list of gdb.RecordInstruction, gdb.RecordGap or gdb.RecordAuxiliary
> objects.
>
> This patch is in preparation for the new ptwrite feature, which is based on
> auxiliary instructions.
>
> gdb/ChangeLog:
> 2021-06-14 Felix Willgerodt <felix.willgerodt@intel.com>
>
> * py-record-btrace.c (btpy_insn_or_gap_new): Removed.
> (btpy_item_new): New function.
> (btpy_list_item): Call btpy_item_new instead of recpy_insn_new.
> (recpy_bt_replay_position): Call btpy_item_new instead of
> btpy_insn_or_gap_new.
> (recpy_bt_begin): Call btpy_item_new instead of btpy_insn_or_gap_new.
> (recpy_bt_end): Call btpy_item_new instead of btpy_insn_or_gap_new.
> * py-record.c (recpy_aux_type): New static object.
> (recpy_aux_object): New typedef.
> (recpy_aux_new, recpy_aux_number, recpy_aux_data): New function.
> (recpy_aux_getset): New static object.
> (gdbpy_initialize_record): Initialize gdb.RecordAuxiliary type.
>
> gdb/doc/ChangeLog:
> 2021-06-14 Felix Willgerodt <felix.willgerodt@intel.com>
>
> * python.texi (gdb.RecordAuxiliary): New documentation.

The documentation part is OK, thanks.