Re: [PATCH v2 12/12] btrace: Extend ptwrite event decoding.

Eli Zaretskii via Gdb-patches
2021-06-15T13:52:59Z

> From: "Willgerodt, Felix" <felix.willgerodt@intel.com>
> CC: "Metzger, Markus T" <markus.t.metzger@intel.com>,
> "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
> Date: Tue, 15 Jun 2021 13:40:40 +0000
>
> >> +@smallexample
> >> +@group
> >> +(gdb) python-interactive
> >> +>>> class my_listener(object):
> >> +... def __init__(self):
> >> +... self.variable = 0
> >> +... def __call__(self, payload, ip):
> >> +... if gdb.selected_thread().global_num == 1:
> >> +... self.variable += 1
> >> +... return "payload: @{@}, ip: @{:#x@}".format(self.variable, ip)
>
> Eli> This line is too long for @smallexample, it will cause overful hbox in the
> Eli> printed version of the manual.
>
> Are you sure? I can't find any overfull hbox message for this line in the output
> of 'make pdf' or the resulting gdb.log. When I shorten the line significantly
> and diff the output of 'make pdf' (and gdb.log) with the long version,
> I see no real difference. There are only underful messages for python.texi for me.

In general, any line longer than about 66 characters in @example and
76 in @smallexample are too long, AFAIR.