From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 0/tgB13uw2CQFAAAWB0awg (envelope-from ) for ; Fri, 11 Jun 2021 19:14:37 -0400 Received: by simark.ca (Postfix, from userid 112) id 0E6661F163; Fri, 11 Jun 2021 19:14:37 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 507C11E813 for ; Fri, 11 Jun 2021 19:14:36 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id E099F39AF430 for ; Fri, 11 Jun 2021 23:14:35 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E099F39AF430 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1623453275; bh=VUkm6obZQTI3MVpFrT9AAlE/qm7XwHdgrVT4cN7WR84=; h=Date:To:Subject:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=WSQg9hamQjhDHoSlz846vPiF46w+oHTrX32bB5Gt2PLEZAfar7IiamvAIeDgm524A GFAyKljzYL75iz95O+CHSHkYGWiSrnjikUg/8wbWa7EkHYk/pvpWmmpDrv+FS1g3jQ FFfPRsRLm8zkeIPxal1nu6x/UmBgvG8+alo8kiLc= Received: from lndn.lancelotsix.com (vps-42846194.vps.ovh.net [IPv6:2001:41d0:801:2000::2400]) by sourceware.org (Postfix) with ESMTPS id DA526384404C for ; Fri, 11 Jun 2021 23:14:16 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org DA526384404C Received: from Plymouth (unknown [IPv6:2a02:390:9086:0:ccd2:26d1:a133:8d62]) by lndn.lancelotsix.com (Postfix) with ESMTPSA id 0009E818D5; Fri, 11 Jun 2021 23:14:15 +0000 (UTC) Date: Sat, 12 Jun 2021 00:14:12 +0100 To: Tom Tromey Subject: Re: [PATCH V5] CTF: multi-CU and archive support Message-ID: <20210611231412.4nlxzgoepaomw6bu@Plymouth> References: <1621297225-2332-1-git-send-email-weimin.pan@oracle.com> <20210610003512.auljolwwl5tmcrvx@Plymouth> <87y2bgfena.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <87y2bgfena.fsf@tromey.com> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.11 (lndn.lancelotsix.com [0.0.0.0]); Fri, 11 Jun 2021 23:14:16 +0000 (UTC) X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Lancelot SIX via Gdb-patches Reply-To: Lancelot SIX Cc: Lancelot SIX via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Fri, Jun 11, 2021 at 12:19:05PM -0600, Tom Tromey wrote: > >>>>> "Lancelot" == Lancelot SIX via Gdb-patches writes: > > Lancelot> Should be > > Lancelot> if (sym != nullptr) > > Agreed. > > >> pst = new ctf_psymtab (name, partial_symtabs, objfile->per_bfd, 0); > > Lancelot> I am a bit confused by this one. As far as I can see, there is no way > Lancelot> it can ever be deleted. Again, I am not so familiar with the code yet > Lancelot> so I might have missed something, but hopefully not. > > psymtabs register themselves with a storage object. > This is unfortunate but it is how it has been done for a long time, and > nobody has bothered to clean it up. > > Tom Thanks for the info. This is something I missed initially. “naked new”s without obvious deletes tend to raise some alarms when I read code… Lancelot.