From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id SC+JCqJrumDtSgAAWB0awg (envelope-from ) for ; Fri, 04 Jun 2021 14:06:26 -0400 Received: by simark.ca (Postfix, from userid 112) id 23E401F163; Fri, 4 Jun 2021 14:06:26 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.5 required=5.0 tests=DKIM_SIGNED, MAILING_LIST_MULTI,RDNS_DYNAMIC,T_DKIM_INVALID,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 41BB11E54D for ; Fri, 4 Jun 2021 14:06:25 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A8AD039A000B for ; Fri, 4 Jun 2021 18:06:24 +0000 (GMT) Received: from mail-pl1-x62f.google.com (mail-pl1-x62f.google.com [IPv6:2607:f8b0:4864:20::62f]) by sourceware.org (Postfix) with ESMTPS id ED5873891C3F for ; Fri, 4 Jun 2021 18:05:45 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org ED5873891C3F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=adacore.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=adacore.com Received: by mail-pl1-x62f.google.com with SMTP id v12so5050933plo.10 for ; Fri, 04 Jun 2021 11:05:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=adacore-com.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to; bh=LhRCryQWCr/GJEwNHjAGN4qmeXSiQZZVYYvAc13zzKc=; b=Anfty8BgzyucQ/0itLoYB5cSm4nfMv4Xb+m/ZU03iwV5SUZbNUwBPS6mPVzKr91GFp 6lWDkEpCQWlHO9Yt/LNVTpAHMZZnyD0rmwGUyqFG9Z6Y73hkck+wBCj/iGA1oBHQAGS/ a5O17YXRZrAkhJHgnA43S93SGguFqaLIpS3NRlgvSs97VDmKtvErDU+OMbP+nWupEDQh 6wfNRST/5d+k+8u3ykwXI9D/a32pvcOKy/nYEf/XkoClFV6ITW3bWLGjOjdmPVczNGqh TPaSz9HKpbSGRfbyE7NXTCsosYKiKiiNICXQlEnwYk878y60IO7S+0ZbLekaHBghZYT+ pk2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to; bh=LhRCryQWCr/GJEwNHjAGN4qmeXSiQZZVYYvAc13zzKc=; b=DLskbdSpPV/lTZoCxGobajLxhPl2BidqtIuw5PSPrsH20I4gMPaPDivPQ/vPXAZDWC n8Hz7baNyiGeyH71DoMZ1VbPAOv4GctWZFCi7Rolgl5j6lPg318/piBbPRCfafTUcIcG NB1GmsPQmw9Ku3X438jXZ3pJEcJvuvCa/WojY3mYGFWqbahJhFr5pI/uxp+zHHAUqIKw OnKQ3bG7jrmjctmGnS1Jap/HarY4C18iZqk0MbPtcEaBJgh2QIqr/RjfYcWo52WQGVCf 9uBBiXabaFbJxJvNhshNJ56LJfy11VzM73oa8xIu7Okb31lKtMdM+/JSJ9bfvfnZ816S Oi2g== X-Gm-Message-State: AOAM532eSToZLFTyBPx8gv9Nlim3MmjXLHOWwlfhnnPJyb/CxXshRr1h Xm7Z6tPtQRa4sdlWcDL9Jook X-Google-Smtp-Source: ABdhPJwURTyphJeNtkdw4oYtCP+JJgN+ab00Dj03PDVdHUt8YtpZL4N9Fiy1w6iQEWZf2+8y2kyFIA== X-Received: by 2002:a17:90a:414a:: with SMTP id m10mr17494623pjg.149.1622829945120; Fri, 04 Jun 2021 11:05:45 -0700 (PDT) Received: from takamaka.home ([184.69.131.86]) by smtp.gmail.com with ESMTPSA id l70sm2711361pgd.20.2021.06.04.11.05.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 04 Jun 2021 11:05:44 -0700 (PDT) Received: by takamaka.home (Postfix, from userid 1000) id 6538989CFF; Fri, 4 Jun 2021 11:05:43 -0700 (PDT) Date: Fri, 4 Jun 2021 11:05:43 -0700 From: Joel Brobecker To: Hannes Domani Subject: Re: [PATCHv3 1/2] Initial TUI mouse support Message-ID: <20210604180543.GB3009@adacore.com> References: <20210603151453.15248-1-ssbssa.ref@yahoo.de> <20210603151453.15248-1-ssbssa@yahoo.de> <87r1hhoi03.fsf@tromey.com> <1760297979.5212997.1622816480782@mail.yahoo.com> <0936428e-80c4-c192-cdfd-817ff9bcfab0@palves.net> <515203848.1443464.1622825294740@mail.yahoo.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <515203848.1443464.1622825294740@mail.yahoo.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Tom Tromey , Joel Brobecker , Hannes Domani via Gdb-patches Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" Hi Pedro and Hannes, Thanks Pedro for having reported this regression. I agree we can't branch with this sort of issue! On Fri, Jun 04, 2021 at 04:48:14PM +0000, Hannes Domani wrote: > Am Freitag, 4. Juni 2021, 18:29:52 MESZ hat Pedro Alves Folgendes geschrieben: > > > On 2021-06-04 4:20 p.m., Pedro Alves wrote: > > > On 2021-06-04 3:21 p.m., Hannes Domani via Gdb-patches wrote: > > >>  Am Freitag, 4. Juni 2021, 15:51:27 MESZ hat Tom Tromey Folgendes geschrieben: > > >> > > >>>>>>>> "Hannes" == Hannes Domani via Gdb-patches writes: > > >>> > > >>> Hannes> Implements an overridable tui_win_info::click method whose arguments > > >>> Hannes> are the mouse coordinates inside the specific window, and the mouse > > >>> Hannes> button clicked. > > >>> > > >>> Hannes> And if the curses implementation supports 5 buttons, the 4th and 5th > > >>> Hannes> buttons are used for scrolling. > > >>> > > >>> Hannes> 2021-06-03  Hannes Domani  > > >>> > > >>> Hannes>     * ser-mingw.c (console_select_thread): Handle MOUSE_EVENT. > > >>> Hannes>     * tui/tui-data.h (struct tui_win_info): Add click function. > > >>> Hannes>     * tui/tui-io.c (tui_prep_terminal): Enable mouse events. > > >>> Hannes>     (tui_deprep_terminal): Disable mouse events. > > >>> Hannes>     (tui_dispatch_ctrl_char): Handle KEY_MOUSE. > > >>> Hannes>     * tui/tui.c (tui_disable): Disable mouse events. > > >>> > > >>> Looks good.  Thank you again. > > >> > > >> Pushed both, thanks. > > >> > > > > > > Yay, mouse support finally.  Thank you! > > > > Unfortunately, now that I try it, it's broken for me.  And it's broken in a very bad way -- I think > > this should block the release or be disabled until we figure out what's wrong.  It definitely > > makes GDB unusable for me. > > > > The trouble is that now pressing anywhere on the screen with the mouse just results in > > weird characters being printed on the command line window (probably uninterpreted control > > sequences).  That even prevents me from selecting text (something I do often) -- I wanted to do > > that to paste the results here.  I even tried suspending GDB with ^Z to then copy the text, but > > that still leaves the mouse messed up.  See this screenshot: > > > >   https://i.imgur.com/bO7FKDO.png > > > > This was on Ubuntu 20.04. > > OK, that's bad. > What's the procedure for this sort or problem? Reverting? > > I didn't expect this kind of problem, it works fine for me on a remote Linux > via putty. If you can reproduce, understand, and fix quickly, we can go with that. Otherwise, for an issue with this kind of effect, we indeed usually start by reverting, or at least disabling the code entirely when that's easily done. -- Joel