From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id drT/B3QhpGAoIgAAWB0awg (envelope-from ) for ; Tue, 18 May 2021 16:20:04 -0400 Received: by simark.ca (Postfix, from userid 112) id 103F71F11C; Tue, 18 May 2021 16:20:04 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 413991E783 for ; Tue, 18 May 2021 16:20:03 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 818DD385781F; Tue, 18 May 2021 20:20:02 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 818DD385781F DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1621369202; bh=0K+oOAg8/KEtNjOAXrIiKBN0JRLAiB69t1Pt2N7PwpE=; h=To:Subject:Date:List-Id:List-Unsubscribe:List-Archive:List-Post: List-Help:List-Subscribe:From:Reply-To:From; b=wsRJUuM0dnI8g5ZImDfYaKGkfWRJ5Dm5nZPIKPkEaVBtJ8FMo2on0JOy9gC2HV4xo TD4t8naoSs9seVvK0+oPEbsb+bJ50Rhx0MtpKobLFm2zrguZ79R9mk3ajAdOF7xxF0 5bl+UL2hpmY3WiVe8BeENNLWiQ1q6f68rLRNNU7M= Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by sourceware.org (Postfix) with ESMTPS id ACD25385781F for ; Tue, 18 May 2021 20:19:59 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org ACD25385781F Received: by mail-qk1-x730.google.com with SMTP id o27so10595879qkj.9 for ; Tue, 18 May 2021 13:19:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=0K+oOAg8/KEtNjOAXrIiKBN0JRLAiB69t1Pt2N7PwpE=; b=tQMeMo8PKNOkxrepzOzlVT0oYwmTRW/LvfCkoniBIfxolJutMkFWxZh6sEGgSSR/bM iLgvN+OKC0h8AB9Kwe1aeJD73COsrYnxEJaMCvR8wsMLnR6gmeJLUifkdW8aGLd4LU6a TCYXAt6MJSRufgOD8raQwKDCdx+rrvlx618N8UXi4V7t2QxcUIqIRjt1aw9Vuak6y+E4 4y3OSmFOB0ES9cYwxQhhWBuGpIbqhjP5VyGCgMoJbQQM5MRny8JETxIV8Owg84Pt75vr xbb475nAzwk4unkf2xAyCf/g+CTktZU4oO3gebXXjLMZELd6safzTeOTtHHHkEjNgI+e Lwmg== X-Gm-Message-State: AOAM532yfIKbSYfogojcVM8qNr0SFdAzkJ3qk4UVM+Z9HiL/urL8bjGt WQf7Vhs1AaGuwSpXRA2ewjcVZU5znGRqXA== X-Google-Smtp-Source: ABdhPJyQGhosakEE0j1otdhMfX3NlM5f3zrE59UoQsb2xLzkl6UokvUgg/Lum/RGk389fLB9+gK0WA== X-Received: by 2002:a37:9547:: with SMTP id x68mr7562269qkd.474.1621369199266; Tue, 18 May 2021 13:19:59 -0700 (PDT) Received: from localhost.localdomain ([2804:7f0:4841:40ad:9dc9:85ce:6858:530f]) by smtp.gmail.com with ESMTPSA id x194sm13649064qkb.79.2021.05.18.13.19.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 May 2021 13:19:58 -0700 (PDT) To: gdb-patches@sourceware.org Subject: [PATCH] [AArch64] Sanitize the address before working with allocation tags Date: Tue, 18 May 2021 17:19:53 -0300 Message-Id: <20210518201953.3491983-1-luis.machado@linaro.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Luis Machado via Gdb-patches Reply-To: Luis Machado Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" Remove the logical tag/top byte from the address whenever we have to work with allocation tags. gdb/ChangeLog: YYYY-MM-DD Luis Machado * aarch64-linux-tdep.c (aarch64_linux_memtag_matches_p): Remove the top byte. (aarch64_linux_set_memtags): Likewise. (aarch64_linux_get_memtag): Likewise. (aarch64_linux_report_signal_info): Likewise. --- gdb/aarch64-linux-tdep.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c index 9602fc4b29a..e9761ed2189 100644 --- a/gdb/aarch64-linux-tdep.c +++ b/gdb/aarch64-linux-tdep.c @@ -1587,7 +1587,8 @@ aarch64_linux_memtag_matches_p (struct gdbarch *gdbarch, CORE_ADDR addr = value_as_address (address); /* Fetch the allocation tag for ADDRESS. */ - gdb::optional atag = aarch64_mte_get_atag (addr); + gdb::optional atag + = aarch64_mte_get_atag (address_significant (gdbarch, addr)); if (!atag.has_value ()) return true; @@ -1625,6 +1626,9 @@ aarch64_linux_set_memtags (struct gdbarch *gdbarch, struct value *address, } else { + /* Remove the top byte. */ + addr = address_significant (gdbarch, addr); + /* Make sure we are dealing with a tagged address to begin with. */ if (!aarch64_linux_tagged_address_p (gdbarch, address)) return false; @@ -1679,6 +1683,8 @@ aarch64_linux_get_memtag (struct gdbarch *gdbarch, struct value *address, if (!aarch64_linux_tagged_address_p (gdbarch, address)) return nullptr; + /* Remove the top byte. */ + addr = address_significant (gdbarch, addr); gdb::optional atag = aarch64_mte_get_atag (addr); if (!atag.has_value ()) @@ -1751,7 +1757,8 @@ aarch64_linux_report_signal_info (struct gdbarch *gdbarch, uiout->field_core_addr ("fault-addr", gdbarch, fault_addr); uiout->text ("\n"); - gdb::optional atag = aarch64_mte_get_atag (fault_addr); + gdb::optional atag + = aarch64_mte_get_atag (address_significant (gdbarch, fault_addr)); gdb_byte ltag = aarch64_mte_get_ltag (fault_addr); if (!atag.has_value ()) -- 2.25.1